Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed rules: version support #15

Closed
wants to merge 8 commits into from
Closed

Conversation

tsunamaru
Copy link

what

This PR introducing version argument support for Managed Rule group.

why

See linked issue for more details.

references

Closes #14

@tsunamaru tsunamaru requested review from a team as code owners April 29, 2022 08:26
@tsunamaru tsunamaru requested review from srhopkins and brcnblc April 29, 2022 08:26
@tsunamaru
Copy link
Author

Caveat: this change will require you explicitly set version = null to unversioned rules (e.g. AWSManagedRulesAmazonIpReputationList). I'm not sure what would be best approach here, so feel free to advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruleset version support
3 participants