You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current Thrift definition for the filters_changed method includes an optional parameter filter_names. However, the generated Rust code treats this parameter as if it cannot be None, which leads to inconsistencies and limitations in our implementation.
Specifically, we need the ability to differentiate between cases where filter_names is not provided, is an empty list, or contains specific filter names. This distinction is crucial for handling filtering logic accurately in our application.
Proposal
As @Millione proposed here, treat default parameters as required (current behavior), but optional as optional.
The text was updated successfully, but these errors were encountered:
Feature Request
Crates
pilota-build
pilota-thrift-parser
Motivation
The current Thrift definition for the filters_changed method includes an optional parameter filter_names. However, the generated Rust code treats this parameter as if it cannot be None, which leads to inconsistencies and limitations in our implementation.
Specifically, we need the ability to differentiate between cases where filter_names is not provided, is an empty list, or contains specific filter names. This distinction is crucial for handling filtering logic accurately in our application.
Proposal
As @Millione proposed here, treat default parameters as required (current behavior), but optional as optional.
The text was updated successfully, but these errors were encountered: