Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop starting server when app build fails #72

Open
minump opened this issue Nov 14, 2023 · 0 comments
Open

Stop starting server when app build fails #72

minump opened this issue Nov 14, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@minump
Copy link
Collaborator

minump commented Nov 14, 2023

On npm start, the react client app builds first and then starts the express server. Even if the react client app build fails, the express server is started.
Stop if the react client app build fails.
In the webpack config run (https://github.com/clowder-framework/CONSORT-frontend/blob/main/tools/build.js#L16), when there is build errors, it returns a 1 or returns the errors. However this return is not captured in the npm start command (https://github.com/clowder-framework/CONSORT-frontend/blob/main/package.json#L14) .
The commands for react client build and express server start should be separated out and the express server start should be triggered only after successful client build.

@minump minump self-assigned this Nov 14, 2023
@minump minump added the bug Something isn't working label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant