Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onlyOwner on funding round and funding round factory contract where possible #608

Open
yuetloo opened this issue Dec 14, 2022 · 0 comments

Comments

@yuetloo
Copy link
Collaborator

yuetloo commented Dec 14, 2022

This is to allow functions to be executable by anyone, not just the owner.

For example, the fundingRoundFactory.transferMatchingFunds() can be run by anyone because:

  1. if a round has not been deployed, the call will fail
  2. if the round is not finalized, the call will fail
  3. if the tally has not been completed, the call will also fail.
@yuetloo yuetloo changed the title Remove onlyOwner on funding round or funding round factory contract where possible Remove onlyOwner on funding round and funding round factory contract where possible Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant