Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit timeout error if socket connection dies silently #37

Open
clue opened this issue Dec 1, 2022 · 0 comments
Open

Emit timeout error if socket connection dies silently #37

clue opened this issue Dec 1, 2022 · 0 comments
Labels
help wanted Extra attention is needed new feature New feature or request
Milestone

Comments

@clue
Copy link
Owner

clue commented Dec 1, 2022

This project already supports reconnecting with a retry timer when the connection closes (#7/#26). Additionally, we should consider a connection to be dead if we did not receive any data for a timeout period (default could be 600s?). The server is expected to send regular heartbeat/ping messages (such as the empty comment :\n) to keep the connection alive if there is no activity (each 15-60s seems reasonable). This is particularly useful in the event where the socket connection may die silently such as due to power outages or network failure.

Refs clue/reactphp-redis#132, https://github.com/reactphp/http#timeouts, https://launchdarkly.github.io/dotnet-eventsource/api/LaunchDarkly.EventSource.ReadTimeoutException.html

We welcome contributions, reach out if you want to support this project or become a sponsor ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed new feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants