Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on PHP 8.3 and update test suite #54

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Nov 13, 2023

This pull request builds on top of #46, #47 and #48.

References: clue/reactphp-csv#33, reactphp/socket#300 and reactphp/socket#299.

After this pull request is merged, we can continue with #53.

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that we're still using the old ubuntu-20.04 in our PHPUnit job within the ci.yml file. I believe this should also be updated to ubuntu-22.04, just like you did for the PHPUnit-hhvm job.

@SimonFrings SimonFrings added documentation Improvements or additions to documentation new feature and removed documentation Improvements or additions to documentation labels Nov 14, 2023
@yadaiio
Copy link
Contributor Author

yadaiio commented Nov 14, 2023

Tysm @SimonFrings for sharpening my eyes for this ! I totally didn't saw this in the first place. Whoops. But it should be alright now! 🥳

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes, looking good 👍

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for looking into this, changes LGTM! :shipit:

@clue clue merged commit 4f9cf0a into clue:1.x Nov 17, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants