Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A release with promise v3 unlocked #148

Closed
WyriHaximus opened this issue Dec 12, 2023 · 4 comments
Closed

A release with promise v3 unlocked #148

WyriHaximus opened this issue Dec 12, 2023 · 4 comments
Milestone

Comments

@WyriHaximus
Copy link
Contributor

Got a request for one of my packages to include promise v3 support over at WyriHaximus/reactphp-cache-redis#59. It seems this package's next version branch has support for it through #145 and #134. What are the plans for releasing that?

@SimonFrings
Copy link
Contributor

Good question @WyriHaximus!

The current version that we're working on is the v3 as this is also the only milestone currently open and planned. This milestone will bring some API changes and improvements and will ensure compatibility with the upcoming ReactPHP v3. Also talked with @clue that redis v3 probably won't be compatible with ReactPHP v1, so we'll have to wait for the ReactPHP v3 components before releasing redis v3.

With all this in mind, I think it's safe to say that redis v3 will take a while before going live, but we think it's a good idea to backport some features (PHP 8.3 compatibility from #147, promise v3 support from #150, etc.) to v2. We can then release an additional version for v2, so you can use this version for now until redis v3 gets released.

We'll work on backporting the needed features, will keep you posted as we progress 👍

@WyriHaximus
Copy link
Contributor Author

Sounds like a plan @SimonFrings, it was mainly about unlocking the way done in #152 . Template types and such will come in v3, doing a simular pattern with my own packages where one release will unlock it, and the next will drop previous version + adds all the v3 goodies.

@yadaiio
Copy link
Contributor

yadaiio commented Jan 5, 2024

Closed via #152.

@yadaiio yadaiio closed this as completed Jan 5, 2024
@WyriHaximus
Copy link
Contributor Author

Thanks, just released https://github.com/WyriHaximus/reactphp-cache-redis/releases/tag/4.5.0 with that release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants