diff --git a/commands/service.go b/commands/service.go index bbf4c0e4582..e8bf689d59a 100644 --- a/commands/service.go +++ b/commands/service.go @@ -35,22 +35,7 @@ type arduinoCoreServerImpl struct { versionString string } -// Version FIXMEDOC +// Version returns the version of the Arduino CLI func (s *arduinoCoreServerImpl) Version(ctx context.Context, req *rpc.VersionRequest) (*rpc.VersionResponse, error) { return &rpc.VersionResponse{Version: s.versionString}, nil } - -// SupportedUserFields FIXMEDOC -func (s *arduinoCoreServerImpl) SupportedUserFields(ctx context.Context, req *rpc.SupportedUserFieldsRequest) (*rpc.SupportedUserFieldsResponse, error) { - return SupportedUserFields(ctx, req) -} - -// ListProgrammersAvailableForUpload FIXMEDOC -func (s *arduinoCoreServerImpl) ListProgrammersAvailableForUpload(ctx context.Context, req *rpc.ListProgrammersAvailableForUploadRequest) (*rpc.ListProgrammersAvailableForUploadResponse, error) { - return ListProgrammersAvailableForUpload(ctx, req) -} - -// EnumerateMonitorPortSettings FIXMEDOC -func (s *arduinoCoreServerImpl) EnumerateMonitorPortSettings(ctx context.Context, req *rpc.EnumerateMonitorPortSettingsRequest) (*rpc.EnumerateMonitorPortSettingsResponse, error) { - return EnumerateMonitorPortSettings(ctx, req) -} diff --git a/commands/service_monitor_settings.go b/commands/service_monitor_settings.go index d69164d281d..4eb71c7add9 100644 --- a/commands/service_monitor_settings.go +++ b/commands/service_monitor_settings.go @@ -25,7 +25,7 @@ import ( ) // EnumerateMonitorPortSettings returns a description of the configuration settings of a monitor port -func EnumerateMonitorPortSettings(ctx context.Context, req *rpc.EnumerateMonitorPortSettingsRequest) (*rpc.EnumerateMonitorPortSettingsResponse, error) { +func (s *arduinoCoreServerImpl) EnumerateMonitorPortSettings(ctx context.Context, req *rpc.EnumerateMonitorPortSettingsRequest) (*rpc.EnumerateMonitorPortSettingsResponse, error) { pme, release, err := instances.GetPackageManagerExplorer(req.GetInstance()) if err != nil { return nil, err diff --git a/commands/service_upload.go b/commands/service_upload.go index 7990b8aaf79..2c01f7edaef 100644 --- a/commands/service_upload.go +++ b/commands/service_upload.go @@ -41,7 +41,7 @@ import ( // SupportedUserFields returns a SupportedUserFieldsResponse containing all the UserFields supported // by the upload tools needed by the board using the protocol specified in SupportedUserFieldsRequest. -func SupportedUserFields(ctx context.Context, req *rpc.SupportedUserFieldsRequest) (*rpc.SupportedUserFieldsResponse, error) { +func (s *arduinoCoreServerImpl) SupportedUserFields(ctx context.Context, req *rpc.SupportedUserFieldsRequest) (*rpc.SupportedUserFieldsResponse, error) { if req.GetProtocol() == "" { return nil, &cmderrors.MissingPortProtocolError{} } diff --git a/commands/service_upload_list_programmers.go b/commands/service_upload_list_programmers.go index 0e02d36c25a..f05142cf147 100644 --- a/commands/service_upload_list_programmers.go +++ b/commands/service_upload_list_programmers.go @@ -25,7 +25,7 @@ import ( ) // ListProgrammersAvailableForUpload FIXMEDOC -func ListProgrammersAvailableForUpload(ctx context.Context, req *rpc.ListProgrammersAvailableForUploadRequest) (*rpc.ListProgrammersAvailableForUploadResponse, error) { +func (s *arduinoCoreServerImpl) ListProgrammersAvailableForUpload(ctx context.Context, req *rpc.ListProgrammersAvailableForUploadRequest) (*rpc.ListProgrammersAvailableForUploadResponse, error) { pme, release, err := instances.GetPackageManagerExplorer(req.GetInstance()) if err != nil { return nil, err diff --git a/internal/cli/arguments/completion.go b/internal/cli/arguments/completion.go index ad0f9d1f1b8..c42e817cc0f 100644 --- a/internal/cli/arguments/completion.go +++ b/internal/cli/arguments/completion.go @@ -18,7 +18,6 @@ package arguments import ( "context" - "github.com/arduino/arduino-cli/commands" f "github.com/arduino/arduino-cli/internal/algorithms" "github.com/arduino/arduino-cli/internal/cli/instance" rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1" @@ -58,7 +57,7 @@ func GetInstalledProgrammers(ctx context.Context, srv rpc.ArduinoCoreServiceServ installedProgrammers := make(map[string]string) for _, board := range list.GetBoards() { - programmers, _ := commands.ListProgrammersAvailableForUpload(context.Background(), &rpc.ListProgrammersAvailableForUploadRequest{ + programmers, _ := srv.ListProgrammersAvailableForUpload(ctx, &rpc.ListProgrammersAvailableForUploadRequest{ Instance: inst, Fqbn: board.GetFqbn(), }) diff --git a/internal/cli/compile/compile.go b/internal/cli/compile/compile.go index 8deba88efad..389065db755 100644 --- a/internal/cli/compile/compile.go +++ b/internal/cli/compile/compile.go @@ -255,7 +255,7 @@ func runCompileCommand(cmd *cobra.Command, args []string, srv rpc.ArduinoCoreSer var uploadRes *rpc.UploadResult if compileError == nil && uploadAfterCompile { - userFieldRes, err := commands.SupportedUserFields(context.Background(), &rpc.SupportedUserFieldsRequest{ + userFieldRes, err := srv.SupportedUserFields(ctx, &rpc.SupportedUserFieldsRequest{ Instance: inst, Fqbn: fqbn, Protocol: port.GetProtocol(), diff --git a/internal/cli/monitor/monitor.go b/internal/cli/monitor/monitor.go index 975f68ba1dd..1e9eddbde53 100644 --- a/internal/cli/monitor/monitor.go +++ b/internal/cli/monitor/monitor.go @@ -147,7 +147,7 @@ func runMonitorCmd( feedback.FatalError(err, feedback.ErrGeneric) } - enumerateResp, err := commands.EnumerateMonitorPortSettings(context.Background(), &rpc.EnumerateMonitorPortSettingsRequest{ + enumerateResp, err := srv.EnumerateMonitorPortSettings(ctx, &rpc.EnumerateMonitorPortSettingsRequest{ Instance: inst, PortProtocol: portProtocol, Fqbn: fqbn, diff --git a/internal/cli/upload/upload.go b/internal/cli/upload/upload.go index c7500adfe98..b3d89259817 100644 --- a/internal/cli/upload/upload.go +++ b/internal/cli/upload/upload.go @@ -118,7 +118,7 @@ func runUploadCommand(srv rpc.ArduinoCoreServiceServer, args []string, uploadFie defaultProtocol := sketch.GetDefaultProtocol() fqbn, port := arguments.CalculateFQBNAndPort(&portArgs, &fqbnArg, inst, srv, defaultFQBN, defaultAddress, defaultProtocol) - userFieldRes, err := commands.SupportedUserFields(context.Background(), &rpc.SupportedUserFieldsRequest{ + userFieldRes, err := srv.SupportedUserFields(ctx, &rpc.SupportedUserFieldsRequest{ Instance: inst, Fqbn: fqbn, Protocol: port.GetProtocol(),