Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Plugin support and maintenance #48

Open
b1rdex opened this issue Feb 14, 2017 · 25 comments
Open

Plugin support and maintenance #48

b1rdex opened this issue Feb 14, 2017 · 25 comments
Milestone

Comments

@b1rdex
Copy link

b1rdex commented Feb 14, 2017

@cmazx this plugin is still actively used by many yii1 developers. Can you please adapt it for current PhpStorm version? I think it's even possible to donate some money for this.

/cc @sjoller @thiagotalma @nkostadinov @narration-sd @ivan-pomortsev @Rafalsky @unst @kanuhamru @vizh as per they had some bugs reported and might be interested in donated plugin maintenance too.

@cmazx
Copy link
Owner

cmazx commented Feb 14, 2017

I will try to find time

@cmazx cmazx added this to the 0.9.17 milestone Feb 19, 2017
@cmazx
Copy link
Owner

cmazx commented Feb 19, 2017

Need testing bugfix https://github.com/cmazx/yiistorm/blob/0.9.17/YiiStorm.jar
Looks like "views" reference broken =))

@b1rdex
Copy link
Author

b1rdex commented Feb 21, 2017

@cmazx works good, no errors for 3 days.

@samdark
Copy link
Contributor

samdark commented Feb 21, 2017

@cmazx time to publish it to JetBrains?

@cmazx
Copy link
Owner

cmazx commented Feb 21, 2017

Plz check references working between
controller->view
view->view

I hope finish this bugfix version on this weekend.

@b1rdex
Copy link
Author

b1rdex commented Feb 21, 2017 via email

@cmazx
Copy link
Owner

cmazx commented Feb 21, 2017

Eh, there is a problem with references =) i will fix it on weekend)

@b1rdex
Copy link
Author

b1rdex commented Feb 22, 2017

@cmazx I have following project structure:

protected
├── controllers
│   └── GoodController.php
├── modules
│   └── auth
│       ├── AuthModule.php
│       ├── controllers
│       │   └── DefaultController.php
│       └── views
│           └── default
│               ├── additional_verification.php
│               ├── change_password.php
│               ├── check_humanity.php
│               └── remember_password.php
├── themes
│   ├── default
│   │   └── views
│   │       ├── good
│   │       │   ├── _orders_list.php
│   │       │   └── view.php
│   │       └── layouts
│   │           └── main.php
│   └── mobile
│       └── views
│           ├── auth
│           │   └── default
│           │       ├── change_password.php
│           │       ├── check_humanity.php
│           │       └── remember_password.php
│           └── layouts
│               ├── column1.php
│               ├── main1260.php
│               └── main.php
└── widgets
    └── ActiveMixedOrdersWidget
        ├── ActiveMixedOrdersWidget.php
        └── views
            ├── index.php
            ├── _type1.php
            └── _type2.php

AFAIK this is supported by yii1 by default.

@cmazx
Copy link
Owner

cmazx commented Feb 22, 2017

ok

@cmazx
Copy link
Owner

cmazx commented Feb 23, 2017

Bug with references fixed.
https://github.com/cmazx/yiistorm/blob/0.9.17/YiiStorm.jar

@b1rdex
Copy link
Author

b1rdex commented Mar 21, 2017

@cmazx missed your message. Tested views navigation.
View-view navigations work.
Controller-view navigations doesn't (both single controller and controller in module).

Widget-view navigation doesn't work.
View-view in widget views works.

PhpStorm 2017.1 EAP
Build #PS-171.3780.55, built on March 15, 2017
PhpStorm EAP User
Expiration date: April 14, 2017
JRE: 1.8.0_112-release-736-b11 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

@cmazx
Copy link
Owner

cmazx commented Mar 21, 2017

thx

@b1rdex
Copy link
Author

b1rdex commented Mar 22, 2017

image

Completion of view name works and new view is created with plus option. But not reference.

@b1rdex
Copy link
Author

b1rdex commented May 26, 2017

@cmazx ping.

@cmazx
Copy link
Owner

cmazx commented Jun 3, 2017

https://github.com/cmazx/yiistorm/blob/0.9.18/YiiStorm.jar?raw=true
Lets try this one =) Yii2 migrations support added.
Referenses seems work.

@b1rdex
Copy link
Author

b1rdex commented Jun 5, 2017

No, it doesn't work for me. It became even worse than before, no I can't find any view references that works. Tested controller-view and view-view, nothing works.

Completion of view name works and new view is created with plus option. But not reference.

These stopped to work.

@cmazx
Copy link
Owner

cmazx commented Jun 5, 2017

strange )

@jalal-o
Copy link

jalal-o commented Jun 16, 2017

I have just tested 0.9.18 it on 2017.1.4 but references also don't work for me.

@cmazx
Copy link
Owner

cmazx commented Jun 17, 2017

@jalal-o
Copy link

jalal-o commented Jun 17, 2017

Unfortunately still doesn't work. 'Cannot find declaration to go to'

@cmazx
Copy link
Owner

cmazx commented Jun 19, 2017

I check on another os and it also works.
Firstly try with removing old version and installing new.
If not works, give me your java and os version.
And file structure in project.

@b1rdex
Copy link
Author

b1rdex commented Jun 19, 2017

@cmazx controller → view navigation doesn't work for me. View→view navigation works again.

PhpStorm 2017.2 EAP
Build #PS-172.2465.7, built on May 24, 2017
PhpStorm EAP User
Expiration date: June 23, 2017
JRE: 1.8.0_152-release-855-b1 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

I pasted project structure before.

@cmazx
Copy link
Owner

cmazx commented Jun 19, 2017

Ok i will check on your project structure.

@b1rdex
Copy link
Author

b1rdex commented Jun 19, 2017

What project structure do you test on when you say it works?
Maybe it'd be better to add test (automated or just php structure for manual test) to be clear what works and what doesn't?

@cmazx
Copy link
Owner

cmazx commented Jun 19, 2017

Yep =) will be better. Manually i check on simple controller-view, view-view and in module.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants