From 921d0b3d9eb1d024598f7c22ed4537e0d1ec8994 Mon Sep 17 00:00:00 2001
From: Christer van der Meeren <christer@infotech.no>
Date: Fri, 8 Sep 2023 11:14:01 +0200
Subject: [PATCH] Optimize BeSuperset(Of)/BeSubset(Of)

---
 src/Faqt/SeqAssertions.fs | 63 +++++++++++++++++++++++++++++----------
 1 file changed, 47 insertions(+), 16 deletions(-)

diff --git a/src/Faqt/SeqAssertions.fs b/src/Faqt/SeqAssertions.fs
index b7e5cf5..ffb18ef 100644
--- a/src/Faqt/SeqAssertions.fs
+++ b/src/Faqt/SeqAssertions.fs
@@ -24,6 +24,45 @@ module private SeqAssertionsHelpers =
     }
 
 
+    let getMissingFromSupersetAndIsProperSuperset superset subset =
+        let freqMap = Dictionary()
+
+        let increment item =
+            let key = Key item
+
+            let newCount =
+                match freqMap.TryGetValue(key) with
+                | false, _ -> 1
+                | true, count -> count + 1
+
+            freqMap[key] <- newCount
+            newCount
+
+        let decrement item =
+            let key = Key item
+
+            let newCount =
+                match freqMap.TryGetValue(key) with
+                | false, _ -> -1
+                | true, count -> count - 1
+
+            freqMap[key] <- newCount
+            newCount
+
+        superset |> Seq.iter (increment >> ignore)
+        subset |> Seq.iter (decrement >> ignore)
+
+        let containedItemNotInSubset = freqMap |> Seq.exists (fun kvp -> kvp.Value > 0)
+
+        let extraItemsInSubset = ResizeArray()
+
+        for item in subset do
+            if increment item < 1 then
+                extraItemsInSubset.Add item
+
+        extraItemsInSubset, containedItemNotInSubset
+
+
 [<Extension>]
 type SeqAssertions =
 
@@ -652,17 +691,13 @@ type SeqAssertions =
         if isNull (box t.Subject) then
             t.With("Subset", subset).With("But was", t.Subject).Fail(because)
 
-        let remaining = ResizeArray(subset)
-        let mutable containedItemNotInSubset = false
+        let extraItemsInSubset, containedItemNotInSubset =
+            getMissingFromSupersetAndIsProperSuperset t.Subject subset
 
-        for item in t.Subject do
-            if not (remaining.Remove item) then
-                containedItemNotInSubset <- true
-
-        if remaining.Count > 0 then
+        if extraItemsInSubset.Count > 0 then
             t
                 .With("Subset", subset)
-                .With("But lacked", remaining)
+                .With("But lacked", extraItemsInSubset)
                 .With("Subject value", t.Subject)
                 .Fail(because)
         elif proper && not containedItemNotInSubset then
@@ -698,17 +733,13 @@ type SeqAssertions =
         if isNull (box t.Subject) then
             t.With("Superset", superset).With("But was", t.Subject).Fail(because)
 
-        let remaining = ResizeArray(t.Subject)
-        let mutable containedItemNotInSubset = false
-
-        for item in superset do
-            if not (remaining.Remove item) then
-                containedItemNotInSubset <- true
+        let extraItemsInSubject, containedItemNotInSubset =
+            getMissingFromSupersetAndIsProperSuperset superset t.Subject
 
-        if remaining.Count > 0 then
+        if extraItemsInSubject.Count > 0 then
             t
                 .With("Superset", superset)
-                .With("But had extra items", remaining)
+                .With("But had extra items", extraItemsInSubject)
                 .With("Subject value", t.Subject)
                 .Fail(because)
         elif proper && not containedItemNotInSubset then