Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-axis rotation #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jennyfothergill
Copy link
Member

@jennyfothergill jennyfothergill commented Oct 26, 2021

Fixes #9

This PR attempts to add z-axis rotations based on the "up" value from the fresnel camera. This also adds buttons to the gui to rotate the diffraction pattern and scene by 5 degrees.

gixstapose_rotate

  • figure out why the rotation breaks after clicking the alignment buttons
  • is the diffraction pattern off by 90degrees?
  • the rotation seems to break or reverse sometimes?

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #11 (56c114c) into master (4f5e50e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   92.67%   92.69%   +0.02%     
==========================================
  Files           4        4              
  Lines         314      315       +1     
==========================================
+ Hits          291      292       +1     
  Misses         23       23              
Impacted Files Coverage Δ
gixstapose/main.py 94.73% <100.00%> (+0.29%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix z-axis rotations
1 participant