Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow picking dependency types in 'scram b checkdeps' #103

Open
kpedro88 opened this issue Mar 7, 2024 · 6 comments
Open

Allow picking dependency types in 'scram b checkdeps' #103

kpedro88 opened this issue Mar 7, 2024 · 6 comments

Comments

@kpedro88
Copy link

kpedro88 commented Mar 7, 2024

git cms-checkdeps allows selecting different kinds of dependencies (header, python, or BuildFile). Right now, scram b checkdeps always checks all of them. Often, I find cases where I want to skip the python dependencies (the python dependency check is very broad and often gives false positives) but keep the others. Could arguments similar to the git version be provided for the scram version?

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

A new Issue was created by @kpedro88.

@rappoccio, @makortel, @sextonkennedy, @antoniovilela, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

@kpedro88 , scram b passes most of the flags to make so scram b checkdeps <git-cms-checkdeps-opts> is not going to work. I can update the build rules so that one can do CHECKDEPS_OPTS='<opts> scram b checkdeps ( where scram then passes <opts> to git-cms-checkdeps . Will this be good enough ? Note that this type of change will only work in the release with updated build rules.

@kpedro88
Copy link
Author

Thanks @smuzaffar. Having it in new releases is better than not having it at all.

As an aside, it would be nice if these various options/environment variables/etc. were documented somewhere... e.g. scram b checkdeps doesn't show up anywhere in the scram help messages.

@smuzaffar
Copy link
Contributor

@kpedro88 , checkdeps is a build rule and to get help on build rules you need to run scram b help in the cmssw dev area

@kpedro88
Copy link
Author

@smuzaffar now I recall that you've actually told me this before... but it only works in $CMSSW_BASE/src, not $CMSSW_BASE/src/X/Y (in the latter it just prints Doing "scram build" here will build every thing exist under this directory.). Maybe this could at least be clarified in the scram --help listing for the "help" build target?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants