Skip to content

Commit

Permalink
fixes a few bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
Zonespace27 committed Sep 16, 2024
1 parent 1e7152b commit 7ca0020
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/// In case they drop their primary but get a new one in the time it takes to retrieve their old one
/datum/ongoing_action/item_pickup/pickup_primary
name = "Pickup Primary"

/datum/ongoing_action/item_pickup/pickup_primary/trigger_action()
if(brain.primary_weapon)
return ONGOING_ACTION_COMPLETED
return ..()
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@

if(dropped == primary_weapon)
set_primary_weapon(null)
ADD_ONGOING_ACTION(src, /datum/ongoing_action/item_pickup, dropped)
ADD_ONGOING_ACTION(src, /datum/ongoing_action/item_pickup/pickup_primary, dropped)
for(var/slot in container_refs)
if(container_refs[slot] == dropped)
appraise_inventory(slot == "belt", slot == "backpack", slot == "left_pocket", slot == "right_pocket")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
return

var/datum/human_ai_faction/faction_obj = SShuman_ai.human_ai_factions[gotten_faction]
var/gotten_input = tgui_input_list(ui.user, "Set which faction being neutral to [gotten_faction]?", "Add Neutral Faction", (FACTION_LIST_HUMANOID + FACTION_LIST_XENOMORPH) - faction_obj.get_neutral_factions())
var/gotten_input = tgui_input_list(ui.user, "Set which faction being neutral to [gotten_faction]?", "Add Neutral Faction", (FACTION_LIST_HUMANOID + FACTION_LIST_XENOMORPH) - faction_obj.get_neutral_factions() - faction_obj.faction)
if(!gotten_input)
return

Expand All @@ -124,7 +124,7 @@
return

var/datum/human_ai_faction/faction_obj = SShuman_ai.human_ai_factions[gotten_faction]
var/gotten_input = tgui_input_list(ui.user, "Set which faction being friendly to [gotten_faction]?", "Add Friendly Faction", (FACTION_LIST_HUMANOID + FACTION_LIST_XENOMORPH) - faction_obj.get_friendly_factions())
var/gotten_input = tgui_input_list(ui.user, "Set which faction being friendly to [gotten_faction]?", "Add Friendly Faction", (FACTION_LIST_HUMANOID + FACTION_LIST_XENOMORPH) - faction_obj.get_friendly_factions() - faction_obj.faction)
if(!gotten_input)
return

Expand Down
1 change: 1 addition & 0 deletions colonialmarines.dme
Original file line number Diff line number Diff line change
Expand Up @@ -1981,6 +1981,7 @@
#include "code\modules\mob\living\carbon\human\ai\ai_equipment.dm"
#include "code\modules\mob\living\carbon\human\ai\ai_management_menu.dm"
#include "code\modules\mob\living\carbon\human\ai\faction_management_panel.dm"
#include "code\modules\mob\living\carbon\human\ai\action_datums\pickup_primary.dm"
#include "code\modules\mob\living\carbon\human\ai\action_datums\orders\order_action.dm"
#include "code\modules\mob\living\carbon\human\ai\action_datums\orders\patrol_waypoints.dm"
#include "code\modules\mob\living\carbon\human\ai\brain\ai_brain_communication.dm"
Expand Down
8 changes: 4 additions & 4 deletions tgui/packages/tgui/interfaces/HumanFactionManager.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ const ExistingFaction = (props) => {
content="Add"
onClick={() =>
act('add_friendly_faction', {
faction: faction,
faction: faction.name,
})
}
style={{
Expand All @@ -110,7 +110,7 @@ const ExistingFaction = (props) => {
content="Remove"
onClick={() =>
act('remove_friendly_faction', {
faction: faction,
faction: faction.name,
})
}
style={{
Expand All @@ -126,7 +126,7 @@ const ExistingFaction = (props) => {
content="Add"
onClick={() =>
act('add_neutral_faction', {
faction: faction,
faction: faction.name,
})
}
style={{
Expand All @@ -137,7 +137,7 @@ const ExistingFaction = (props) => {
content="Remove"
onClick={() =>
act('remove_neutral_faction', {
faction: faction,
faction: faction.name,
})
}
style={{
Expand Down

0 comments on commit 7ca0020

Please sign in to comment.