use defines for click modifiers

cmss13-devs · Nov 9, 2023 · d581dd1 · d581dd1
1 parent f3d20ce
commit d581dd1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/code/modules/vehicles/hardpoints/hardpoint.dm b/code/modules/vehicles/hardpoints/hardpoint.dm
@@ -538,7 +538,7 @@
 /obj/item/hardpoint/proc/start_fire(datum/source, atom/object, turf/location, control, params)
 	/*
 	var/list/modifiers = params2list(params)
-	if(modifiers["shift"] || modifiers["ctrl"] || modifiers["alt"] || modifiers["middle"] || modifiers["right"])
+	if(modifiers[SHIFT_CLICK] || modifiers[CTRL_CLICK] || modifiers[ALT_CLICK] || modifiers[MIDDLE_CLICK] || modifiers[RIGHT_CLICK])
 		return
 	*/
 

diff --git a/code/modules/vehicles/multitile/multitile_interaction.dm b/code/modules/vehicles/multitile/multitile_interaction.dm
@@ -376,41 +376,41 @@
 	var/seat = get_mob_seat(source)
 	switch(seat)
 		if(VEHICLE_DRIVER)
-			if(modifiers["shift"] && !modifiers["alt"])
+			if(modifiers[SHIFT_CLICK] && !modifiers[ALT_CLICK])
 				//object.examine(source)
 				return
-			if(modifiers["ctrl"] && !modifiers["alt"])
+			if(modifiers[CTRL_CLICK] && !modifiers[ALT_CLICK])
 				activate_horn()
 				return
 		if(VEHICLE_GUNNER)
-			if(modifiers["shift"] && !modifiers["middle"])
+			if(modifiers[SHIFT_CLICK] && !modifiers[MIDDLE_CLICK])
 				/*
 				if(HAS_FLAG(vehicle_flags, VEHICLE_TOGGLE_SHIFT_CLICK_GUNNER))
 					shoot_other_weapon(source, seat, object)
 				else
 					object.examine(source)
 				*/
 				return
-			if(modifiers["middle"] && !modifiers["shift"])
+			if(modifiers[MIDDLE_CLICK] && !modifiers[SHIFT_CLICK])
 				/*
 				if(!HAS_FLAG(vehicle_flags, VEHICLE_TOGGLE_SHIFT_CLICK_GUNNER))
 					shoot_other_weapon(source, seat, object)
 				*/
 				return
-			if(modifiers["alt"])
+			if(modifiers[ALT_CLICK])
 				//toggle_gyrostabilizer()
 				return
-			if(modifiers["ctrl"])
+			if(modifiers[CTRL_CLICK])
 				//activate_support_module(source, seat, object)
 				return
 		if(VEHICLE_SUPPORT_GUNNER_ONE, VEHICLE_SUPPORT_GUNNER_TWO)
-			if(modifiers["shift"])
+			if(modifiers[SHIFT_CLICK])
 				//object.examine(source)
 				return
-			if(modifiers["middle"] || modifiers["alt"] || modifiers["ctrl"])
+			if(modifiers[MIDDLE_CLICK] || modifiers[ALT_CLICK] || modifiers[CTRL_CLICK])
 				return
 
-	if(modifiers["shift"] || modifiers["middle"] || modifiers["right"])
+	if(modifiers[SHIFT_CLICK] || modifiers[MIDDLE_CLICK] || modifiers[RIGHT_CLICK])
 		return
 
 	var/obj/item/hardpoint/hardpoint = get_mob_hp(source)