adds crappy system for delayed/looping spawns #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FslashN
reviewed
Feb 11, 2024
| /datum/game_master_xeno_spawner/proc/spawn_xenos() | ||
| var/failure = FALSE | ||
|
|
||
| if(fail_if_human_near) |
There was a problem hiding this comment.
If fail_range exists and is not a null, fail_if_human_near may not be needed as the range already signals that it should do something within that range. Could maybe change the range instead of toggling the function, though in practice you probably would rarely want it to work like that.
FslashN
reviewed
Feb 16, 2024
There was a problem hiding this comment.
This has been up on TR for a while, and we've got some feedback about the feature. It can be useful as-is, but the usefulness is limited as you still have to babysit the spawner to an extent, which takes away from the GM's attention.
- It would likely work better if it was tied to vents and tunnels, or had the option to be tied into them.
- Ability to middle click remove the spawner in addition to the menu.
- Ability to spawn only a # of times specified, after which the spawner auto-deletes.
- Ability for it to auto-delete when a marine moves into specified range.
- Ability to modify the range for marine detection.
|
This has been up for a while and doesn't seem like it's being actively developed. We can re-open this in the future if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds buttons to the GM panel allowing for xenomorph spawns to be delayed by up to 1 hour, "looped" so that they repeat on the same delay, and hidden from players by failing if any living, connected humans are found within 9 tiles (this effect applies for non-delayed spawns as well, if the toggle is pressed). These spawns can then be teleported to or deleted remotely via the panel.
the approach here is sort of crappy, but i'm not sure whether /obj/effect s are as ubiquitous here for effects like these as they are on other codebases, or how to make effects visible to GMs only.
Explain why it's good for the game
Makes it easier for GMs to juggle multiple things at once by letting them set up spawns in advance, while preventing those spawns from breaking the fourth wall.
Testing Photographs and Procedure
i tested it well enough. didnt take screenshots and i am currently very tired
Changelog
🆑
add: Added delayed, looped, and "hidden" xenomorph spawns for GMs.
/:cl: