MK1 Mag Boxes and 10x28mm ammo cans #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FslashN
reviewed
Feb 18, 2024
| @@ -279,6 +280,8 @@ var/global/list/datum/stack_recipe/cardboard_recipes = list ( \ | |||
| new/datum/stack_recipe("empty rifle ammo box (10x24mm Incen)", /obj/item/ammo_box/rounds/incen/empty), \ | |||
| new/datum/stack_recipe("empty rifle ammo box (10x24mm LE)", /obj/item/ammo_box/rounds/le/empty), \ | |||
| null, \ | |||
| new/datum/stack_recipe("empty rifle ammo box (10x28mm)", /obj/item/ammo_box/rounds/smartgun/empty), \ | |||
There was a problem hiding this comment.
Shouldn't this be drum or something like that?
There was a problem hiding this comment.
Shouldn't this be drum or something like that?
This particular one is a box of loose ammo, not drums, that you use to repack drums. I could maybe rename it to smartgun ammo box. Unfortunately I don't think sentry drums support repacking despite being the same cartridge.
| //----------------10x28mm Ammunition Boxes (for smartguns)------------------ | ||
|
|
||
| /obj/item/ammo_box/rounds/smartgun | ||
| name = "\improper rifle ammunition box (10x28mm)" |
There was a problem hiding this comment.
Made tweaks. I think I did this correctly? Not sure, still working my way through figuring out github properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, these items were both missing from base CM code. This allows empty ammo cans for 10x28mm (smartgun ammo) to be crafted from cardboard and an empty mag box for MK1 magazines which will be a massive quality of life increase as our ammo just sits on the dropship to be flamed. This should theoretically make life even the slightest bit easier for GMs when it comes to resupplying platoons in round as well. MK1 boxes have been requested a few times from the community.