Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports a few Dropship PRs #154

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

private-tristan
Copy link
Contributor

@private-tristan private-tristan commented Mar 18, 2024

About the pull request

ports PRs:
Dropship sidedoors
Pried dropship's hatches cannot be locked again
Lockdown actually closes doors on DS
Dropship doors can now always be broken by queen

and also updates the midway/cyclone to have their own double doors

Explain why it's good for the game

I like dropship sidedoors a lot.

Testing Photographs and Procedure

messed around on a private server, made sure the dirs actually worked, loaded each shuttle from template. I did notice that the dropship lockdown buttons (the door controls) don't actually work unless it's the normandy and im not sure why.

Changelog

🆑 ihatethisengine, doubleumc, private-tristan
add: Ported doubledoors from main CM
/:cl:

@FslashN
Copy link
Contributor

FslashN commented Mar 18, 2024

The dropship lockdown button probably has the wrong ID, mismatched to the doors used on the Alamo or whatever. I noticed this bug on CM a few months ago.

@AndroBetel
Copy link
Contributor

AndroBetel commented Mar 21, 2024

i'm gonna testmerge this on RED after you fix that one tiny little mistake i've spotted,

@AndroBetel
Copy link
Contributor

TM'd on red

@FslashN
Copy link
Contributor

FslashN commented Mar 27, 2024

Any issues with this TM'd? If not, I think we can merge it in.

@FslashN FslashN merged commit 2a371a9 into cmss13-devs:master Mar 29, 2024
33 checks passed
Max-023 pushed a commit to Max-023/PvE-CMSS13 that referenced this pull request Mar 30, 2024
Haven't heard of any issue about this. Should be good for the game as a general improvement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants