Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ARC to the epic APC roster #214

Merged
merged 8 commits into from
May 13, 2024
Merged

Conversation

DexterDude
Copy link
Contributor

@DexterDude DexterDude commented Apr 5, 2024

Adds the ARC to PVE.

Essentially it is just a reskinned APC intended for smaller unit sizes, namely FORECON but I can see it being used with the standard platoon as well. All stats are the same as the APC, with the exception of the frontal cannon which has a higher fire rate in exchange for having no IFF. This ammo can go quick, too.

APC exterior sprites by: Esselnek
APC interior sprites (with the exception of the door) by: Žydras

@DexterDude DexterDude marked this pull request as draft April 5, 2024 16:16
@morrowwolf
Copy link
Member

Link the PR you're porting from please

@DexterDude
Copy link
Contributor Author

Link the PR you're porting from please

This isn't a port. It's essentially just a reskinned APC, nothing is borrowed from the code over on PVP, just the sprites made by esselnek. Unless that still counts as a "port?"

@DexterDude DexterDude marked this pull request as ready for review April 17, 2024 20:22
@FslashN
Copy link
Contributor

FslashN commented May 1, 2024

Need someone familiar with vehicles to look over this.

@FslashN FslashN requested a review from Doubleumc May 1, 2024 02:21
code/modules/vehicles/interior/areas.dm Outdated Show resolved Hide resolved
code/modules/vehicles/apc/arc.dm Outdated Show resolved Hide resolved
code/modules/vehicles/hardpoints/primary/arc_frontal.dm Outdated Show resolved Hide resolved
@Doubleumc
Copy link
Contributor

Oh and to be clear: once the above are addressed everything LGTM

@DexterDude DexterDude requested a review from Doubleumc May 8, 2024 07:19
@DexterDude
Copy link
Contributor Author

Added a weaponless variant for GMs who dont want to deal with guns. Also fixed all the requested changes.

Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndroBetel AndroBetel merged commit 54bc643 into cmss13-devs:master May 13, 2024
35 checks passed
AndroBetel added a commit to kirieee/PvE-CMSS13 that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants