Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movielike Spawning (Satchel on Spawn Removal) #215

Closed
wants to merge 22 commits into from

Conversation

Max-023
Copy link
Contributor

@Max-023 Max-023 commented Apr 5, 2024

Removes satchels from cryospawn loadouts, as personnel lockers have rendered them unnecessary. Additionally, adds the service cap to the PltCO's loadout to complete the service uniform set and adds the officer cap to the wardrobe.

@AmoryBlaine
Copy link
Contributor

The service jackets are a part of the service uniform. The whole ensemble should be in there if you're gonna put the jackets in. You don't see guys walking around with BDUs, combat boots and their service uniform jackets.

@Max-023
Copy link
Contributor Author

Max-023 commented Apr 5, 2024

Fixed

@AmoryBlaine
Copy link
Contributor

I also came to the realization that this will not work properly given that lockers are two to a tile and you would necessarily end up having people's stuff stuck in each other's lockers since you're adding something that isn't designed to be taken out the majority of the time.

@Max-023
Copy link
Contributor Author

Max-023 commented Apr 7, 2024

I'll remove it from the lockers for now then and come up with another way to include them.

@Max-023 Max-023 changed the title Movielike Spawning Movielike Spawning and Boiler Suit Tweaks Apr 7, 2024
@AmoryBlaine
Copy link
Contributor

AmoryBlaine commented Apr 8, 2024

Massive not a fan of you changing the boiler suit and messing with the palettes I worked to find a good feel for. The palette of the officer cap- which I already told you is something that I intended to remove because it is redundant- is the same as the armor. The boilersuit was expressly designed with its own green to stand out.


d501e0e8e0dd2e7956620167831b7ec6

This doesn't look like an improvement over my palette, it's a straight up downgrade. Couple that with the fact it's the exact same palette as the armor means it'll look like this with armor on.


bce03d2aae8ec3d0e41df2346d5ba3a7

@Max-023
Copy link
Contributor Author

Max-023 commented Apr 10, 2024

The boiler suit palette adjustment is more for the fact that I am trying to make sure this PR remains compatible with PR#173. Adjusting CM_hats.dmi would make it conflict with said PR. Once that PR is merged, the plan was to adjust the suits back and make the caps use the boiler suit palette, rather than the officer service uniform.

@Max-023 Max-023 changed the title Movielike Spawning and Boiler Suit Tweaks Movielike Spawning (Satchel on Spawn Removal) Apr 12, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@morrowwolf
Copy link
Member

Conflicts

@morrowwolf morrowwolf marked this pull request as draft April 18, 2024 06:02
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Max-023 Max-023 marked this pull request as ready for review April 23, 2024 20:15
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's nothing in the function any longer you should remove the typepath/proc override.

@AndroBetel AndroBetel marked this pull request as draft April 30, 2024 17:52
@AndroBetel
Copy link
Contributor

stale for more than a month, author seems to be inactive

@AndroBetel AndroBetel closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants