-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Movielike Spawning (Satchel on Spawn Removal) #215
Conversation
This reverts commit b1f8fc5.
The service jackets are a part of the service uniform. The whole ensemble should be in there if you're gonna put the jackets in. You don't see guys walking around with BDUs, combat boots and their service uniform jackets. |
Fixed |
I also came to the realization that this will not work properly given that lockers are two to a tile and you would necessarily end up having people's stuff stuck in each other's lockers since you're adding something that isn't designed to be taken out the majority of the time. |
I'll remove it from the lockers for now then and come up with another way to include them. |
Massive not a fan of you changing the boiler suit and messing with the palettes I worked to find a good feel for. The palette of the officer cap- which I already told you is something that I intended to remove because it is redundant- is the same as the armor. The boilersuit was expressly designed with its own green to stand out. This doesn't look like an improvement over my palette, it's a straight up downgrade. Couple that with the fact it's the exact same palette as the armor means it'll look like this with armor on. |
The boiler suit palette adjustment is more for the fact that I am trying to make sure this PR remains compatible with PR#173. Adjusting CM_hats.dmi would make it conflict with said PR. Once that PR is merged, the plan was to adjust the suits back and make the caps use the boiler suit palette, rather than the officer service uniform. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's nothing in the function any longer you should remove the typepath/proc override.
stale for more than a month, author seems to be inactive |
Removes satchels from cryospawn loadouts, as personnel lockers have rendered them unnecessary. Additionally, adds the service cap to the PltCO's loadout to complete the service uniform set and adds the officer cap to the wardrobe.