Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes three instances of a negative accuracy bonus #225

Merged

Conversation

AmoryBlaine
Copy link
Contributor

@AmoryBlaine AmoryBlaine commented Apr 8, 2024

About the pull request

Fixes three instances of negative accuracy bonus being applied to the M4A3, 1911 and DEagle generic ammos. Currently the state of the guns affected by this accuracy nerf means you're tossing away a good few rounds per mag for fuckups you have no control over in situations already dire enough to justify the use of a pistol. It makes it unfun to use knowing you're being penalized for using it when it doesn't even really impact the greater aspect of the game. In particular it's bad on the 1911 since you only have 7 rounds anyways

@FslashN
Copy link
Contributor

FslashN commented Apr 8, 2024

Is this actually a fix? Please test these with numbers, because it may be intentional to the performance of the gun.

@FslashN FslashN marked this pull request as draft April 8, 2024 18:51
@bearrrrrrrr
Copy link
Contributor

wtf, this changes all bullets at base
what???

@Ollanius
Copy link

Ollanius commented Apr 8, 2024

I agree.
While sidearms are meant for last-ditch efforts, I don't think that justifies the poor accuracy that they have outside of point-blank range. On the contrary, I think that it's far more cinematic (and pleasing to the common player) if they're able to effectively used their sidearm in one hand while.. say, dragging (or carrying) a critically-injured marine away in the other. Watching as most of your sidearm's magazine miss the Drone that's three or four tiles away from you isn't enjoyable.

For those concerned about the potential imbalances that might come from this pull request, it's important to keep in mind that sidearms are (rightfully) not designed to be used as primary weapons. Increasing the accuracy will not change the fact that they're already balanced by their extremely low capacity (compared to the M41A-MKI Pulse Rifle) , and that it's functionally impossible to gain additional sidearm magazines outside of the USS Golden Arrow. To note:

  • The M4A3's capacity is 12+1.
  • The M44R's capacity is 7.
  • The M1911/M48A1's capacity is 7+1.
  • The M88's capacity is 18+1.
  • The VP78's capacity is 18+1.

Assuming that you're taking them in a shoulder-holster, that's anywhere from 21 to 36 rounds in total. If you're taking them with a pistol-belt (that requires a suit or belt slot to be worn), then that's about 49 to 126 rounds in total. For comparison, those same slots (with a webbing or ammo belt) can carry 297 to 495 rounds for the M41A-MKI Pulse Rifle. There's no harm that'll come from increasing the accuracy of these sidearms, in my opinion.

Copy link
Contributor

@AndroBetel AndroBetel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vasquez killed a warrior with a pistol

@AndroBetel AndroBetel marked this pull request as ready for review June 2, 2024 12:24
@AndroBetel AndroBetel enabled auto-merge (squash) June 2, 2024 12:24
@AndroBetel AndroBetel merged commit 48aca9e into cmss13-devs:master Jun 2, 2024
36 checks passed
@AmoryBlaine AmoryBlaine deleted the M4A3-and-1911-accuracy-fix branch June 18, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants