Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildmode & GM panel compatability #267

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Doubleumc
Copy link
Contributor

About the pull request

Allows multiple click intercept sources (ex/buildmode, GM panel, rappel panel) to coexist peacefully. It remembers all sources and the most recent source takes priority.

Instead of a single click_intercept, there's now a list of click_intercepts. Any activated intercept source will add itself to the list, and will remove itself when deactivated. The last source in the list (the most recent) gets the clicks.

Significantly adjusted how the GM panel handled its multiple intercepts to work with the new system. Should be the exact same for the user.

Explain why it's good for the game

Buildmode and the GM panel are used every round, frequently at the same time. This PR allows them to be used side-by-side in a much smoother way than one nuking the other's click intercept if that control is closed.

Testing Photographs and Procedure

Boots without issue. Tested having buildmode, GM panel, rappel panel all open at the same time. Closing one allows the others to still function.

Changelog

🆑
qol: buildmode & GM panel don't stomp on each other's clicks
/:cl:

@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Doubleumc Doubleumc marked this pull request as draft August 27, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants