sg harness name fix #268
Merged
sg harness name fix #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doubleumc
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Doesn't fully achieve your goal. Harnesses can still spawn with incorrect names.
cmss13-pve/code/modules/clothing/suits/marine_armor.dm
Lines 405 to 406 in 8547eaf
On a cold map it compares the name
"\improper M56 combat harness" with "M56 combat harness", fails, and never renames it (which should be "\improper M56 snow combat harness" anyway)
The
standard subtype redefines flags_atom without including NO_NAME_OVERRIDE
|
Feel free to reopen when the issues have been addressed. |
…to sg_harness_name_fix
Doubleumc
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds NO_NAME_OVERRIDE so its displayed properly now