-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crates Are More Cratier #309
Conversation
…t's a 50/50 if someone's filled them with useless crap. Funni.
What are all the other not mentioned changes for |
This isn't really useful or adding much. I recommend you instead just create a series of crate loadouts for various locations and factions as a mapper resource. Also, the soap addition seems needless. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's my opinion on this.
You should say what you are changing and why you are changing it in the PR. Right now all I know is that some changes were made to crates to make them cratier because it's funny.
That doesn't exactly give me a good description of what you want to do nor what you are doing with the PR. Obviously I can see the files changed, but generally you should make it easy to view and go "oh these changes as a whole are neat" or "oh these changes as a whole are bad".
I have a few questions, namely, why did you make this PR and why did you make the specific changes? Without knowing this, all of the changes you have made seem kinda nonsensical. Why is clothing removed but sheets are added for example?
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Guh. I was going to go somewhere with this and try to make different crate subtypes but this is already so far ebhind im not considering it worth the effort to bring up. |
Summary (but actually when im not eepy)