From 9b6d361bd1f54884f6e4c3981d14841569415b64 Mon Sep 17 00:00:00 2001 From: AndroBetel <44546836+AndroBetel@users.noreply.github.com> Date: Wed, 21 Aug 2024 23:06:30 +0300 Subject: [PATCH 1/3] 1 --- code/game/objects/items/devices/motion_detector.dm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/code/game/objects/items/devices/motion_detector.dm b/code/game/objects/items/devices/motion_detector.dm index 60cf62b4e2..8cfe126daf 100644 --- a/code/game/objects/items/devices/motion_detector.dm +++ b/code/game/objects/items/devices/motion_detector.dm @@ -231,6 +231,8 @@ ping_count++ if(human_user) show_blip(human_user, M) + for(var/mob/living/carbon/human/humans in range(1, human_user)) + show_blip(humans, M) for(var/mob/hologram/holo as anything in GLOB.hologram_list) if(!holo.motion_sensed) From d5091979d8e0339fb808c007355eece4bbaedaed Mon Sep 17 00:00:00 2001 From: AndroBetel <44546836+AndroBetel@users.noreply.github.com> Date: Sat, 24 Aug 2024 23:10:53 +0300 Subject: [PATCH 2/3] reviews --- code/game/objects/items/devices/motion_detector.dm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/code/game/objects/items/devices/motion_detector.dm b/code/game/objects/items/devices/motion_detector.dm index 8cfe126daf..4ef6b6529a 100644 --- a/code/game/objects/items/devices/motion_detector.dm +++ b/code/game/objects/items/devices/motion_detector.dm @@ -217,6 +217,10 @@ range_bounds.set_shape(cur_turf.x, cur_turf.y, detector_range * 2) + var/list/ping_receivers = list() + for(var/mob/living/carbon/human/humans in range(1, human_user)) + ping_receivers += humans + var/list/ping_candidates = SSquadtree.players_in_range(range_bounds, cur_turf.z, QTREE_EXCLUDE_OBSERVER | QTREE_SCAN_MOBS) for(var/A in ping_candidates) @@ -230,9 +234,8 @@ apply_debuff(M) ping_count++ if(human_user) - show_blip(human_user, M) - for(var/mob/living/carbon/human/humans in range(1, human_user)) - show_blip(humans, M) + for(var/mob/living/carbon/human/show_ping_to in ping_receivers) + show_blip(show_ping_to, M) for(var/mob/hologram/holo as anything in GLOB.hologram_list) if(!holo.motion_sensed) From 2b6c2e3f3b4b0009bdc398997ce9d78e23b1e080 Mon Sep 17 00:00:00 2001 From: AndroBetel <44546836+AndroBetel@users.noreply.github.com> Date: Sat, 24 Aug 2024 23:47:45 +0300 Subject: [PATCH 3/3] Update code/game/objects/items/devices/motion_detector.dm Co-authored-by: Doubleumc --- code/game/objects/items/devices/motion_detector.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/game/objects/items/devices/motion_detector.dm b/code/game/objects/items/devices/motion_detector.dm index 4ef6b6529a..4e72795510 100644 --- a/code/game/objects/items/devices/motion_detector.dm +++ b/code/game/objects/items/devices/motion_detector.dm @@ -234,7 +234,7 @@ apply_debuff(M) ping_count++ if(human_user) - for(var/mob/living/carbon/human/show_ping_to in ping_receivers) + for(var/mob/living/carbon/human/show_ping_to as anything in ping_receivers) show_blip(show_ping_to, M) for(var/mob/hologram/holo as anything in GLOB.hologram_list)