Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM button: toggle vehicle blockers #75

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

Doubleumc
Copy link
Contributor

About the pull request

A convenient button to enable/disable those invisible vehicle blockers.

image
image

Explain why it's good for the game

Significantly more convenient than the existing methods.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: gm button to toggle vehicle blockers
/:cl:

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having it be a mode toggle I'd far prefer a global list of all vehicle blockers that have an active var that we toggle on/off.

We're confined to a certain number of bitflags and we're starting to walk closer to the limit.

Secondly, and I'm happy to do this if you don't get to it, could you add another section that's just "flags" or "toggles". Should be just changing the categories of this and the other one to "Game Master.Toggles"

@morrowwolf morrowwolf marked this pull request as draft November 23, 2023 15:28
@Doubleumc
Copy link
Contributor Author

Changed it to work like "Toggle LZ Weeding"/"Toggle OB Spawn" where it toggles a global variable that the effected system checks.

Moved "Toggle Vehicle Blockers" and "Toggle Xeno Spawning" to the Flags section to mirror the Admin tab.

@Doubleumc Doubleumc marked this pull request as ready for review November 26, 2023 00:22
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise fine

code/modules/admin/admin_verbs.dm Show resolved Hide resolved
@morrowwolf morrowwolf marked this pull request as draft November 28, 2023 07:00
@Doubleumc Doubleumc marked this pull request as ready for review November 28, 2023 20:17
@morrowwolf morrowwolf enabled auto-merge (squash) December 1, 2023 23:45
@morrowwolf morrowwolf merged commit a7d2e30 into cmss13-devs:master Dec 1, 2023
30 checks passed
@Doubleumc Doubleumc deleted the GM-toggle-vehicle-blockers branch December 1, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants