Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes roundstart announcements #81

Closed

Conversation

private-tristan
Copy link
Contributor

@private-tristan private-tristan commented Nov 26, 2023

About the pull request

Marines will no longer receive an announcement about what's going on when they wake up, leaving it solely to the PLTCO to inform them of what's happening.

also removes the ARES ONLINE text

Explain why it's good for the game

morrow had this listed on the to-do sheet
image

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Private Tristan
del: Marines no longer get an announcement at roundstart about the colony going dark.
del: ARES no announces itself at roundstart.
/:cl:

@private-tristan
Copy link
Contributor Author

linters failed but PR works fine.
image

@harryob
Copy link
Member

harryob commented Nov 26, 2023

linters failed but PR works fine. image

click in annotate lints

CleanShot 2023-11-26 at 20 35 18@2x

@@ -10,11 +10,6 @@
var/datum/emergency_call/picked_calls[] = list() //Which distress calls are currently active
var/ert_dispatched = FALSE

/datum/game_mode/proc/ares_online()
Copy link
Member

@morrowwolf morrowwolf Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just override these functions on the ai gamemode please, leave everything else so we can avoid conflicts.

This and the map announcement.

@morrowwolf morrowwolf marked this pull request as draft November 28, 2023 06:58
@private-tristan
Copy link
Contributor Author

going to make a different branch for this because github desktop is being difficult.

@private-tristan private-tristan deleted the announce-text-gone branch November 30, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants