Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pain code minor cleanup #96

Merged

Conversation

private-tristan
Copy link
Contributor

About the pull request

removes some useless signal removals because the signals themselves weren't registered

Explain why it's good for the game

Testing Photographs and Procedure

while I didn't record it, I did boot up a server and made sure that devouring still killls with 200 pain, and that when i set pain to 0 it doesn't.

Changelog

no player facing changes.

Copy link
Contributor

@FslashN FslashN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. There is only one signal handler, so it does seem like the other stuff was either left over from something else or didn't get implemented in the first place.

@morrowwolf morrowwolf merged commit f35b8fe into cmss13-devs:master Feb 1, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants