From 07ebad740aa08f7177e261589ffcf947745e17aa Mon Sep 17 00:00:00 2001 From: morrowwolf Date: Mon, 2 Oct 2023 10:09:16 -0400 Subject: [PATCH] "Fixes" missing window frame icon states (#4534) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # About the pull request This PR "fixes" missing window frame icon states by just checking if they exist and if not then defaulting to base. The vast majority of these are missing states 5, 6, 7, 9, 10, 11, 13, 14, 15 but some have them and others do not. It's essentially a bandaid but until we get someone who wants to sprite 100ish icons 🤷 closes https://github.com/cmss13-devs/cmss13/issues/2531 # Explain why it's good for the game Dealing with invisible window frames is super frustrating for everyone. # Testing Photographs and Procedure
Screenshots & Videos Put screenshots and videos here with an empty line between the screenshots and the `
` tags.
# Changelog :cl: Morrow fix: "Fixed" missing window frame icon states /:cl: --- code/game/smoothwall.dm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/code/game/smoothwall.dm b/code/game/smoothwall.dm index a06ed7750c26..eb81861a3b1f 100644 --- a/code/game/smoothwall.dm +++ b/code/game/smoothwall.dm @@ -170,6 +170,11 @@ setDir(NORTH) /obj/structure/window/framed/handle_icon_junction(jun_1, jun_2) + if(!icon_exists(icon, "[basestate][jun_2 ? jun_2 : jun_1]")) //Missing states for 5, 6, 7, 9, 10, 11, 13, 14, 15 for the vast majority of /obj/structure/window/framed + icon_state = "[basestate]0" + junction = 0 + return + icon_state = "[basestate][jun_2 ? jun_2 : jun_1]" //Use junction 2 if possible, junction 1 otherwise. if(jun_2) junction = jun_2 @@ -177,6 +182,11 @@ junction = jun_1 /obj/structure/window_frame/handle_icon_junction(jun_1, jun_2) + if(!icon_exists(icon, "[basestate][jun_2 ? jun_2 : jun_1]_frame")) //Missing states for 5, 6, 7, 9, 10, 11, 13, 14, 15 for the vast majority of /obj/structure/window_frame + icon_state = "[basestate]0_frame" + junction = 0 + return + icon_state = "[basestate][jun_2 ? jun_2 : jun_1]_frame" //Use junction 2 if possible, junction 1 otherwise. if(jun_2) junction = jun_2