From 2d8fa5510c74f5a19c433ae875d4f96c6580488b Mon Sep 17 00:00:00 2001
From: Steelpoint <6595389+Steelpoint@users.noreply.github.com>
Date: Wed, 4 Oct 2023 17:02:27 +0800
Subject: [PATCH] Minor QOL Buff To Handheld Crew Monitor (#4545)
# About the pull request
Adds the job title of a person to the crew list on the handheld crew
monitor. Also expands the default screen size of the radar menu so the
user can see the entire name and job title of the crew.
# Explain why it's good for the game
Makes the monitor slightly easier to use. Helps differentiate who
exactly you are looking at.
# Testing Photographs and Procedure
Screenshots & Videos
![Screenshot 2023-09-29 14 31
45](https://github.com/cmss13-devs/cmss13/assets/6595389/6bc15031-50e9-475c-9d00-22e13979fd38)
# Changelog
:cl:
ui: Added personnel job titles to the handheld crew monitor, to make it
easier to tell find out exactly what role's you are looking for. Also
slightly expands the default monitor screen size to accommodate the
entire personnel text on screen.
/:cl:
Co-authored-by: Steelpoint
---
code/modules/cm_marines/radar.dm | 9 ++++++---
tgui/packages/tgui/interfaces/Radar.tsx | 4 ++--
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/code/modules/cm_marines/radar.dm b/code/modules/cm_marines/radar.dm
index 5e85ff8950c7..f6751a8fe913 100644
--- a/code/modules/cm_marines/radar.dm
+++ b/code/modules/cm_marines/radar.dm
@@ -204,17 +204,20 @@
if(!trackable(humanoid))
continue
var/crewmember_name = "Unknown"
+ var/crewmember_rank = "Unknown"
if(humanoid.wear_id)
var/obj/item/card/id/ID = humanoid.wear_id.GetID()
if(ID?.registered_name)
crewmember_name = ID.registered_name
+ if(ID?.assignment)
+ crewmember_rank = ID.assignment
switch(humanoid.stat)
if(CONSCIOUS)
- crewmember_name = "[crewmember_name] (Conscious)"
+ crewmember_name = "[crewmember_name] ([crewmember_rank]) (Conscious)"
if(UNCONSCIOUS)
- crewmember_name = "[crewmember_name] (Unconscious)"
+ crewmember_name = "[crewmember_name] ([crewmember_rank]) (Unconscious)"
if(DEAD)
- crewmember_name = "[crewmember_name] (DEAD)"
+ crewmember_name = "[crewmember_name] ([crewmember_rank]) (DEAD)"
var/list/crewinfo = list(
ref = REF(humanoid),
name = crewmember_name,
diff --git a/tgui/packages/tgui/interfaces/Radar.tsx b/tgui/packages/tgui/interfaces/Radar.tsx
index 1664082fb1b8..277d23f12d1b 100644
--- a/tgui/packages/tgui/interfaces/Radar.tsx
+++ b/tgui/packages/tgui/interfaces/Radar.tsx
@@ -29,7 +29,7 @@ type Target = {
export const Radar = (props, context) => {
return (
-
+
@@ -40,7 +40,7 @@ export const Radar = (props, context) => {
export const RadarContent = (props, context) => {
return (
-
+