ARES Security Log Fix (#3997)

# About the pull request Fixes ARES security logs to actually appear # Explain why it's good for the game MFW a major overhaul has a line or two of code missing that makes it have parts that doesn't work. # Changelog :cl: fix: ARES security logs now are properly displayed /:cl: --------- Co-authored-by: forest2001 <[email protected]>
cmss13-devs · Jul 26, 2023 · 7252fe5 · 7252fe5
1 parent ff1060d
commit 7252fe5
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/code/game/machinery/ARES/ARES.dm b/code/game/machinery/ARES/ARES.dm
@@ -137,7 +137,7 @@
 	/// The current deleted chat log of 1:1 conversations being read.
 	var/list/deleted_1to1 = list()
 
-	/// Holds all (/datum/ares_record/announcement)s and (/datum/ares_record/security/security_alert)s
+	/// Holds all (/datum/ares_record/announcement)s
 	var/list/records_announcement = list()
 	/// Holds all (/datum/ares_record/bioscan)s
 	var/list/records_bioscan = list()

diff --git a/code/game/machinery/ARES/ARES_procs.dm b/code/game/machinery/ARES/ARES_procs.dm
@@ -223,7 +223,7 @@ GLOBAL_LIST_INIT(maintenance_categories, list(
 	data["records_announcement"] = logged_announcements
 
 	var/list/logged_alerts = list()
-	for(var/datum/ares_record/security/security_alert as anything in records_announcement)
+	for(var/datum/ares_record/security/security_alert as anything in records_security)
 		if(!istype(security_alert))
 			continue
 		var/list/current_alert = list()
@@ -457,6 +457,10 @@ GLOBAL_LIST_INIT(maintenance_categories, list(
 					new_title = "[record.title] at [record.time]"
 					new_details = record.details
 					records_announcement -= record
+				if(ARES_RECORD_SECURITY)
+					new_title = "[record.title] at [record.time]"
+					new_details = record.details
+					records_security -= record
 				if(ARES_RECORD_BIOSCAN)
 					new_title = "[record.title] at [record.time]"
 					new_details = record.details

diff --git a/tgui/packages/tgui/interfaces/AresInterface.js b/tgui/packages/tgui/interfaces/AresInterface.js
@@ -1268,8 +1268,14 @@ const AntiAir = (props, context) => {
 
 const Security = (props, context) => {
   const { data, act } = useBackend(context);
-  const { logged_in, access_text, last_page, current_menu, records_security } =
-    data;
+  const {
+    logged_in,
+    access_text,
+    last_page,
+    current_menu,
+    records_security,
+    access_level,
+  } = data;
 
   return (
     <>