From 8988653d1d54b27203b1b9c577cf38e7decf52dc Mon Sep 17 00:00:00 2001 From: Doubleumc Date: Mon, 23 Sep 2024 04:22:22 -0400 Subject: [PATCH] Clear armor lamp overlays (#7191) # About the pull request Before adding a new armor lamp overlay, remove the old one. # Explain why it's good for the game Potentially infinitely stacking overlays bad. # Testing Photographs and Procedure
Screenshots & Videos Master, toggling lamp 10x: ![image](https://github.com/user-attachments/assets/4af9239c-01a3-4227-8fca-e97eb250d0d8) PR, toggling lamp 10x: ![image](https://github.com/user-attachments/assets/2780a33b-6eed-4c7d-a20f-f3bf798ad20d)
# Changelog No player facing changes. --- code/modules/clothing/suits/marine_armor/_marine_armor.dm | 1 + 1 file changed, 1 insertion(+) diff --git a/code/modules/clothing/suits/marine_armor/_marine_armor.dm b/code/modules/clothing/suits/marine_armor/_marine_armor.dm index 0ba339433fc2..138de402fbe4 100644 --- a/code/modules/clothing/suits/marine_armor/_marine_armor.dm +++ b/code/modules/clothing/suits/marine_armor/_marine_armor.dm @@ -137,6 +137,7 @@ /obj/item/clothing/suit/storage/marine/update_icon(mob/user) var/image/I + overlays -= armor_overlays["lamp"] armor_overlays["lamp"] = null if(flags_marine_armor & ARMOR_LAMP_OVERLAY) if(flags_marine_armor & ARMOR_LAMP_ON)