From ae6715b3dd0dd3f55d0a0e78f0df97560936a4c9 Mon Sep 17 00:00:00 2001
From: harryob <me@harryob.live>
Date: Thu, 20 Jul 2023 13:44:42 +0100
Subject: [PATCH 1/2] prevents bad vars being touched (#3932)

apparently this wasn't ported with the rest of the vv refactor whoops!

:cl:
admin: you can no longer touch bad vars
/:cl:
---
 code/game/atoms_movable.dm | 17 +++++++++++++++++
 code/game/turfs/turf.dm    |  6 ++++++
 2 files changed, 23 insertions(+)

diff --git a/code/game/atoms_movable.dm b/code/game/atoms_movable.dm
index 6b980136bc9e..17b37ce76630 100644
--- a/code/game/atoms_movable.dm
+++ b/code/game/atoms_movable.dm
@@ -74,6 +74,23 @@
 		var/client/C = usr.client
 		C?.open_particle_editor(src)
 
+/atom/movable/vv_edit_var(var_name, var_value)
+	var/static/list/banned_edits = list(NAMEOF_STATIC(src, step_x) = TRUE, NAMEOF_STATIC(src, step_y) = TRUE, NAMEOF_STATIC(src, step_size) = TRUE, NAMEOF_STATIC(src, bounds) = TRUE)
+	var/static/list/careful_edits = list(NAMEOF_STATIC(src, bound_x) = TRUE, NAMEOF_STATIC(src, bound_y) = TRUE, NAMEOF_STATIC(src, bound_width) = TRUE, NAMEOF_STATIC(src, bound_height) = TRUE)
+	var/static/list/not_falsey_edits = list(NAMEOF_STATIC(src, bound_width) = TRUE, NAMEOF_STATIC(src, bound_height) = TRUE)
+	if(banned_edits[var_name])
+		return FALSE //PLEASE no.
+	if(careful_edits[var_name] && (var_value % world.icon_size) != 0)
+		return FALSE
+	if(not_falsey_edits[var_name] && !var_value)
+		return FALSE
+
+	if(!isnull(.))
+		datum_flags |= DF_VAR_EDITED
+		return
+
+	return ..()
+
 //when a mob interact with something that gives them a special view,
 //check_eye() is called to verify that they're still eligible.
 //if they are not check_eye() usually reset the mob's view.
diff --git a/code/game/turfs/turf.dm b/code/game/turfs/turf.dm
index 6e98f4d7c065..bc0375e0b850 100644
--- a/code/game/turfs/turf.dm
+++ b/code/game/turfs/turf.dm
@@ -118,6 +118,12 @@
 	VV_DROPDOWN_OPTION(VV_HK_EXPLODE, "Trigger Explosion")
 	VV_DROPDOWN_OPTION(VV_HK_EMPULSE, "Trigger EM Pulse")
 
+/turf/vv_edit_var(var_name, new_value)
+	var/static/list/banned_edits = list(NAMEOF_STATIC(src, x), NAMEOF_STATIC(src, y), NAMEOF_STATIC(src, z))
+	if(var_name in banned_edits)
+		return FALSE
+	. = ..()
+
 /turf/ex_act(severity)
 	return 0
 

From 152021785da4d88c79531d0db0ef35bb06b594e8 Mon Sep 17 00:00:00 2001
From: cm13-github <128137806+cm13-github@users.noreply.github.com>
Date: Thu, 20 Jul 2023 14:06:12 +0100
Subject: [PATCH 2/2] Automatic changelog for PR #3932 [ci skip]

---
 html/changelogs/AutoChangeLog-pr-3932.yml | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 html/changelogs/AutoChangeLog-pr-3932.yml

diff --git a/html/changelogs/AutoChangeLog-pr-3932.yml b/html/changelogs/AutoChangeLog-pr-3932.yml
new file mode 100644
index 000000000000..df7c88fa0e2a
--- /dev/null
+++ b/html/changelogs/AutoChangeLog-pr-3932.yml
@@ -0,0 +1,4 @@
+author: "harryob"
+delete-after: True
+changes:
+  - admin: "you can no longer touch bad vars"
\ No newline at end of file