From d703ba496a6b547e7275ff84697afbec1cb37916 Mon Sep 17 00:00:00 2001 From: blackdragonTOW <31581761+blackdragonTOW@users.noreply.github.com> Date: Wed, 19 Jun 2024 15:03:57 -0700 Subject: [PATCH] still mastering the concept of early returns --- code/game/machinery/nuclearbomb.dm | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/code/game/machinery/nuclearbomb.dm b/code/game/machinery/nuclearbomb.dm index d074a5080949..c936dfff47e8 100644 --- a/code/game/machinery/nuclearbomb.dm +++ b/code/game/machinery/nuclearbomb.dm @@ -632,22 +632,18 @@ GLOBAL_VAR_INIT(bomb_set, FALSE) /obj/structure/machinery/nuclearbomb/tech/attackby(obj/item/nuke_disk as obj, mob/user as mob) var/reduction_multiplier = 0.7 //30% reduction - if(istype(nuke_disk, /obj/item/disk/nuclear)) + if(!istype(nuke_disk, /obj/item/disk/nuclear)) attack_hand(user) - if(decrypting) - if (decryption_time > 0) - decryption_end_time = LERP(world.time, decryption_end_time, reduction_multiplier) - decryption_time = decryption_end_time - world.time - to_chat(user, SPAN_WARNING("The decryption process begins using the disk's data...")) - announce_to_players() //Let everyone know the new time - qdel(nuke_disk) - return - else - to_chat(user, SPAN_WARNING("Decryption is already complete...")) - return - else - to_chat(user, SPAN_WARNING("It needs to be decrypting first!")) - return - else to_chat(user, SPAN_WARNING("You probably shouldn't hit it with \the [src]...")) return + if(!decrypting) + to_chat(user, SPAN_WARNING("It needs to be decrypting first!")) + return + if(decryption_time <= 0) + to_chat(user, SPAN_WARNING("Decryption is already complete...")) + return + decryption_end_time = LERP(world.time, decryption_end_time, reduction_multiplier) + decryption_time = decryption_end_time - world.time + to_chat(user, SPAN_WARNING("The decryption process begins using the disk's data...")) + announce_to_players() //Let everyone know the new time + qdel(nuke_disk)