From e02f93f80d7553a414adf9f9bb7a9eb4a8c2e05c Mon Sep 17 00:00:00 2001
From: TeDGamer <107966994+TeDGamer@users.noreply.github.com>
Date: Sat, 9 Sep 2023 17:11:38 -0400
Subject: [PATCH] [Balance] Small xenos ( larva, huggers ) has a smaller chance
 of being hit (#4365)

# About the pull request

Just a part of looking at projectile hit chances.

Noticed that while big xenos had a hit buff, that was it. Decided it
might be good for small ( only larva and huggers, lessers unaffected by
this change ) can get a slight nerf to their hit chance. Basically
opposite of the big hit chance increase.

# Explain why it's good for the game

Well, for small creatures, just a slgihtly better dodge.

Obviously, shouldn't change too much as -10% is a small buff. But should
feel a bit better than consistently dying to stray bullets without even
a chance considering huggers take 3 minutes to respawn.

</details>


# Changelog
:cl:
balance: Huggers and larvas are slightly harder to hit
code: Replace some w_class magic numbers with defines
/:cl:
---
 code/modules/projectiles/projectile.dm | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/code/modules/projectiles/projectile.dm b/code/modules/projectiles/projectile.dm
index de48d8c79be2..4613c59696de 100644
--- a/code/modules/projectiles/projectile.dm
+++ b/code/modules/projectiles/projectile.dm
@@ -677,13 +677,13 @@
 		var/hitchance = P.get_effective_accuracy()
 
 		switch(w_class) //smaller items are harder to hit
-			if(1)
+			if(SIZE_TINY)
 				hitchance -= 50
-			if(2)
+			if(SIZE_SMALL)
 				hitchance -= 30
-			if(3)
+			if(SIZE_MEDIUM)
 				hitchance -= 20
-			if(4)
+			if(SIZE_LARGE)
 				hitchance -= 10
 
 		#if DEBUG_HIT_CHANCE
@@ -756,7 +756,8 @@
 
 	. = P.get_effective_accuracy()
 
-	if(lying && stat) . += 15 //Bonus hit against unconscious people.
+	if(lying && stat)
+		. += 15 //Bonus hit against unconscious people.
 
 	if(isliving(P.firer))
 		var/mob/living/shooter_living = P.firer
@@ -799,7 +800,10 @@
 			if(X.hivenumber == hivenumber)
 				return FALSE
 
-		if(mob_size >= MOB_SIZE_BIG) . += 10
+		if(mob_size == MOB_SIZE_SMALL)
+			. -= 10
+		else if(mob_size >= MOB_SIZE_BIG)
+			. += 10
 		if(evasion > 0)
 			. -= evasion