From 1ad3f1d741722feb8904d6a2758e23f0bfcfdea2 Mon Sep 17 00:00:00 2001
From: Drathek <76988376+Drulikar@users.noreply.github.com>
Date: Thu, 23 May 2024 05:29:19 -0700
Subject: [PATCH 01/26] Fix nanoui onclose errors (#6319)
# About the pull request
This PR fixes some of the errors getting sent (namely with character
preferences window) e.g. `winset: Parameter preferencebrowser.on-close
not found.`
As far as I can tell no behavior actually changes with any of these?
# Explain why it's good for the game
Less clientside errors.
# Testing Photographs and Procedure
Screenshots & Videos
Still opens and closes and saves fine?
![image](https://github.com/cmss13-devs/cmss13/assets/76988376/3abf8156-cc44-4987-a6bb-36cf5be0f474)
# Changelog
:cl: Drathek
fix: Fixed some winset errors with some nanoui windows
/:cl:
---
code/game/machinery/telecomms/machine_interactions.dm | 2 +-
code/game/objects/items/circuitboards/airlock.dm | 2 +-
code/game/objects/items/devices/dummy_tablet.dm | 4 ++--
code/modules/client/preferences.dm | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/code/game/machinery/telecomms/machine_interactions.dm b/code/game/machinery/telecomms/machine_interactions.dm
index 97c393e06556..87bfcd466766 100644
--- a/code/game/machinery/telecomms/machine_interactions.dm
+++ b/code/game/machinery/telecomms/machine_interactions.dm
@@ -160,7 +160,7 @@
dat += ""
temp = ""
show_browser(user, dat, "[src] Access", "tcommachine", "size=520x500;can_resize=0")
- onclose(user, "dormitory")
+ onclose(user, "tcommachine")
// Off-Site Relays
diff --git a/code/game/objects/items/circuitboards/airlock.dm b/code/game/objects/items/circuitboards/airlock.dm
index 4de97a8e20f3..cc6a8e95af0e 100644
--- a/code/game/objects/items/circuitboards/airlock.dm
+++ b/code/game/objects/items/circuitboards/airlock.dm
@@ -58,7 +58,7 @@
t1 += text("
Close
\n", src)
show_browser(user, t1, "Access Control", "airlock_electronics")
- onclose(user, "airlock")
+ onclose(user, "airlock_electronics")
/obj/item/circuitboard/airlock/Topic(href, href_list)
diff --git a/code/game/objects/items/devices/dummy_tablet.dm b/code/game/objects/items/devices/dummy_tablet.dm
index 3ce5f933ab94..4996daf5366e 100644
--- a/code/game/objects/items/devices/dummy_tablet.dm
+++ b/code/game/objects/items/devices/dummy_tablet.dm
@@ -87,8 +87,8 @@
dat += "
\[ Reset \]"
dat += "
"
- show_browser(user, dat, "Professor DUMMY Control Tablet", window_options="size=400x500")
- onclose(user, "communications")
+ show_browser(user, dat, "Professor DUMMY Control Tablet", "dummytablet", window_options="size=400x500")
+ onclose(user, "dummytablet")
updateDialog()
return
diff --git a/code/modules/client/preferences.dm b/code/modules/client/preferences.dm
index 46d217ce25d4..78bcfcb8c0ac 100644
--- a/code/modules/client/preferences.dm
+++ b/code/modules/client/preferences.dm
@@ -651,7 +651,7 @@ GLOBAL_LIST_INIT(bgstate_options, list(
dat += "