Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You can interact with the dummy tablet whilst being away from it. #3291

Closed
2 of 3 tasks
Conchuckter opened this issue May 11, 2023 · 1 comment · Fixed by #4268
Closed
2 of 3 tasks

You can interact with the dummy tablet whilst being away from it. #3291

Conchuckter opened this issue May 11, 2023 · 1 comment · Fixed by #4268
Labels
Bug Admin events aren't bugs Good First Issue Good for newcomers

Comments

@Conchuckter
Copy link

Conchuckter commented May 11, 2023 •
edited
Loading

Testmerges

#3273, #3271, #3088, #3284 and #3290.

Description of the bug

I was able to de-limb and preform other actions on the dummy whilst not in the usually interact-able range (outside a 3x3 grid).

What's the difference with what should have happened?

If outside the range where you should be able to interact with something, it should not allow you to use the tablet.

How do we reproduce this bug?

  1. Pickup Tablet.
  2. Use in hand to open UI.
  3. Drop tablet and walk away.
  4. Attempt to use the functions of the tablet.

Issue Bingo
@Conchuckter Conchuckter added the Bug Admin events aren't bugs label May 11, 2023
@Conchuckter Conchuckter changed the title You can interact with the dummy tablet while distanced from it. You can interact with the dummy tablet whilst being away from it. May 11, 2023
@fira
Copy link
Member

fira commented May 11, 2023

This is an oversight due to related incapacitated/distance check being normally handled in machinery Topic. The tablet being a device, it needs to do these checks itself.

@usnpeepoo usnpeepoo added Oversight Test your code rigorously only for you to overlook something ultra obvious Good First Issue Good for newcomers labels May 11, 2023
@ItsVyzo ItsVyzo removed the Oversight Test your code rigorously only for you to overlook something ultra obvious label Jun 15, 2023
@Xufysz Xufysz mentioned this issue Aug 26, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 28, 2023
@Xufysz
3291 - Fixes the ability to manipulate a dummy from a distance using …
fcef7ad 
…the tablet (#4268)

# About the pull request

Closes #3291 

This code fixes an issue where you can manipulate a dummy at a distance.

# Explain why it's good for the game

N/A, an issue was raised for it.


# Testing Photographs and Procedure


https://github.com/cmss13-devs/cmss13/assets/8283338/40e61fb6-c833-4faa-a0fe-e2423ba7870e

# Changelog

:cl:
fix: Fixes admin training dummy interaction distance
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs Good First Issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3291 - Fixes the ability to manipulate a dummy from a distance using the tablet Xufysz/cmss13
4 participants
@fira @ItsVyzo @usnpeepoo @Conchuckter