Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghosting does not lock a mob from being reentered #3639

Closed
3 tasks done
SupernovaXTS opened this issue Jun 15, 2023 · 0 comments
Closed
3 tasks done

Ghosting does not lock a mob from being reentered #3639

SupernovaXTS opened this issue Jun 15, 2023 · 0 comments
Labels
Bug Admin events aren't bugs

Comments

@SupernovaXTS
Copy link
Contributor

Testmerges

#3470,#3605,#3601,#3298,#3633,#3546

Description of the bug

After a player ghosts with the ooc ghost button, they can reenter their body.
https://youtu.be/XFsU0gjp8h4. Here is my testing of it.

What's the difference with what should have happened?

They should of been given a you do not have a body message.

How do we reproduce this bug?

1.Spawn in as xeno or marine, If xeno wait to mature to non bloody larva
2.Ghost using the ooc tab
3. Reenter body
4. Profit

Issue Bingo
@SupernovaXTS SupernovaXTS added the Bug Admin events aren't bugs label Jun 15, 2023
@ihatethisengine ihatethisengine mentioned this issue Jun 15, 2023
Merged
harryob pushed a commit that referenced this issue Jun 16, 2023
@ihatethisengine
Fixes some issues with ghosts (#3641)
7f5a8c3 
# About the pull request

Fixes bugs and following issues:
#3639
#3635

# Explain why it's good for the game

Bugs bad.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl: TheGamerdk, ihatethisengine
fix: player can no longer come back in their bodies after ghosting 
/:cl:
@harryob harryob closed this as completed Jun 16, 2023
Coolgat3 pushed a commit to Wehland-Yutani/WehYu-Station that referenced this issue Jul 1, 2023
@ihatethisengine
Fixes some issues with ghosts (#3641)
122d73a 
# About the pull request

Fixes bugs and following issues:
cmss13-devs/cmss13#3639
cmss13-devs/cmss13#3635

# Explain why it's good for the game

Bugs bad.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl: TheGamerdk, ihatethisengine
fix: player can no longer come back in their bodies after ghosting 
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harryob @SupernovaXTS