Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Being able to spawn as facehugger despite xenoban #3739

Closed
3 tasks done
JosephBiell opened this issue Jun 27, 2023 · 0 comments · Fixed by #3766
Closed
3 tasks done

Being able to spawn as facehugger despite xenoban #3739

JosephBiell opened this issue Jun 27, 2023 · 0 comments · Fixed by #3766
Labels
Bug Admin events aren't bugs

Comments

@JosephBiell
Copy link

Testmerges

#3601: 'InfluxDB Metrics Backend' by fira at commit 08bdacf #3298: 'Project ARES - Resurrection' by realforest2001 at commit 6c10017 #3644: 'The weeds are hungry: Bodies for the weeds' by Drulikar at commit ae175d1 #3676: 'New Varadero revamp' by AnuvKH at commit 737087d #3666: 'Xenos no longer can pull dead xenos' by morrowwolf at commit dee2162

Description of the bug

I am banned in xenos and despite that i was able to spawn by clicking on eg. join as facehugger still indicates i am banned as xeno , however i am still able to join.

What's the difference with what should have happened?

You should not be able to spawn as xeno when banned (facehugger is a xenomorph)

How do we reproduce this bug?

1.Be banned as xeno
2. Click eg
3. ???
4. Play as Facehugger (despite xeno ban)

Issue Bingo
@JosephBiell JosephBiell added the Bug Admin events aren't bugs label Jun 27, 2023
@Drulikar Drulikar mentioned this issue Jun 29, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 30, 2023
@Drulikar
Fix Facehugger Ban Oversight (#3766)
9b123cc 
# About the pull request

This PR fixes an oversight where the xeno ban check wasn't being done
for facehuggers (except the facehugger join verb).

# Explain why it's good for the game

Fixes #3739 

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/76988376/861eed98-0810-40ed-8a4c-22529cdac345)

</details>

# Changelog
:cl: Drathek
fix: Fixed missing xeno ban check for playing as a facehugger
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Facehugger Ban Oversight Drulikar/cmss13
1 participant
@JosephBiell