Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Welders consume fuel on irrelevant clicks even if no action occurs #3776

Closed
3 tasks done
Wintermote opened this issue Jul 1, 2023 · 0 comments · Fixed by #3959
Closed
3 tasks done

Welders consume fuel on irrelevant clicks even if no action occurs #3776

Wintermote opened this issue Jul 1, 2023 · 0 comments · Fixed by #3959
Labels
Bug Admin events aren't bugs

Comments

@Wintermote
Copy link

Testmerges

#3601, #3644, #3676, #3690, #3755, #3525

Description of the bug

Welders when used in many cases, will consume welding fuel without actually doing anything.

The most common example of this occurring is when repairing cades. If you repair a cade to full health and then click it again at full health (for example: Because you cannot tell in any other way that the cade is fully repaired) the welder will do nothing, you will be told the cade is now fully repaired, and the welder will have its fuel consumed anyway. You can in fact completely consume the entire welder in a couple seconds just from clicking fast on a repaired cade.

This does not only happen with cades. It seems to be virtually any action with the welder on something that the welder cannot complete its operation, will consume welder fuel regardless of any work being done.

This bug has existed for years, I can't imagine there hasn't been a bug report before but I can't find any.

What's the difference with what should have happened?

Expected behaviour:
Clicking on a fully repaired cade does not consume any welding fuel because you do not actually do anything

Actual behaviour:
Clicking on a fully repaired cade consumes welding fuel despite you not actually doing anything

How do we reproduce this bug?

  1. Build a cade
  2. Acquire a welder
  3. Click on the cade with the welder until running out of fuel even though no actions took place

Issue Bingo
@Wintermote Wintermote added the Bug Admin events aren't bugs label Jul 1, 2023
@realkhad realkhad mentioned this issue Jul 21, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 22, 2023
@realkhad
fixes welder tool using up fuel on clicks that produce no action (#3959)
4cded4b 
# About the pull request

you no longer lose your precious fuel if you click on things that can't
be welded (you still lose fuel if you hit mobs)
also got rid of all 1 letter vars in the proc i touched
fixes #3776 

# Explain why it's good for the game

fix good


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:Khadd
fix: blowtorch no longer loses fuel on clicks that produce no action
code: replaced 1-letter vars
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes welder tool using up fuel on clicks that produce no action realkhad/cmss13
1 participant
@Wintermote