Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xeno Tacmap: Leaving it open lets you have it permanently #3888

Closed
3 tasks done
Weuyn opened this issue Jul 14, 2023 · 0 comments · Fixed by #3957
Closed
3 tasks done

Xeno Tacmap: Leaving it open lets you have it permanently #3888

Weuyn opened this issue Jul 14, 2023 · 0 comments · Fixed by #3957
Labels
In Game Exploit If you abuse this, you will be obliterated

Comments

@Weuyn
Copy link
Contributor

Weuyn commented Jul 14, 2023

Testmerges

#3676: 'New Varadero revamp' by AnuvKH at commit 830ed83 #3783: 'Project ARES - Apollo Controller' by realforest2001 at commit c4269d6 #3784: 'Project ARES - APOLLO Console Distribution' by realforest2001 at commit b387f27 #3729: 'Ravager and Hedgehog changes' by GoldenDarkness55 at commit 16b30ac #3850: 'Donator Kits' by realforest2001 at commit 3190146 #3851: 'Removes MSay' by Zonespace27 at commit 25ecd9a #3879: 'Yautja Rework Holder' by realforest2001 at commit 2288622

Description of the bug

If you open the xeno tacmap while queen is on ovi, it will continue to work even after the queen comes off of it or dies.

What's the difference with what should have happened?

There should be some sorta check sent out to force close the tacmap windows of all xenos when the queen leaves her ovipositor.

That said, it's am amazingly useful feature and should probably just be allowed all the time as long a the hive core is up. Way, way better than using hive status to check xenos individually and does the exact same thing mechanically.

How do we reproduce this bug?

  1. queen on her ovipositor
  2. open your tac map as a rando xeno
  3. have the queen go combat capping, you still have it.
    ...

Issue Bingo
@Weuyn Weuyn added the Bug Admin events aren't bugs label Jul 14, 2023
@ItsVyzo ItsVyzo added In Game Exploit If you abuse this, you will be obliterated and removed Bug Admin events aren't bugs labels Jul 20, 2023
@Drulikar Drulikar mentioned this issue Jul 21, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 22, 2023
@Drulikar
Fix Xeno Tacmap Persistence (#3957)
396d2a8 
# About the pull request

This PR makes it so the xeno tacmap will be closed when the queen dies
on ovi, or leaves ovi. Also fixes the xeno tacmap handling of queen
deletion runtiming.

# Explain why it's good for the game

Fixes #3888 

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl: Drathek
fix: Fix xeno tacmap staying open when it should be unavailable
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In Game Exploit If you abuse this, you will be obliterated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Xeno Tacmap Persistence Drulikar/cmss13
2 participants
@ItsVyzo @Weuyn