Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CL lockbox contains wrong ammo [this should probably be labeled a oversight not bug] #3976

Closed
3 tasks done
MusselMain opened this issue Jul 24, 2023 · 0 comments · Fixed by #4071
Closed
3 tasks done

CL lockbox contains wrong ammo [this should probably be labeled a oversight not bug] #3976

MusselMain opened this issue Jul 24, 2023 · 0 comments · Fixed by #4071
Assignees
@Huffie56
Labels
Bug Admin events aren't bugs

Comments

@MusselMain
Copy link

MusselMain commented Jul 24, 2023 •
edited
Loading

Testmerges

PR #3583 Adds a CL-Exclusive pistol, the ES-4

Description of the bug

the CL's WY lockbox spawns with Mod88 mags instead of ES-4 mags, not sure if this is a bug, but as the CL doesn't get a MOD88 by default anymore, and has to go get one from req this makes less sense than before. Maybe this is overthinking things, but wouldn't having extra ammo for the sidearm they actually have access to roundstart make more sense. [if i'm wrong, and this is intended, let me know so i can remove this issue.]

What's the difference with what should have happened?

Lockbox should probably contain ES-4 AMMO, as that's the weapon the CL actually spawns with roundstart.

How do we reproduce this bug?

1.spawn as CL
2. open lockbox in your closet
3.receive ammo for a weapon you don't have

Issue Bingo
@MusselMain MusselMain added the Bug Admin events aren't bugs label Jul 24, 2023
@Huffie56 Huffie56 self-assigned this Jul 31, 2023
@Huffie56 Huffie56 mentioned this issue Jul 31, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 2, 2023
@Huffie56
fix having inapropriate ammo in CL lockbox. (#4071)
859ec23 
# About the pull request
fixes: #3976
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
removing the improper ammo in the lock box because it's obsolete
considering the new gun CL as.
adding a way to buy more ammo so that CL as a way to refill is weapon.
didn't wanted to give it for free in the lockbox.
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/117036822/f9aeb4e9-e11f-4a3f-9ccd-da244ee74713)


![image](https://github.com/cmss13-devs/cmss13/assets/117036822/815b6f6a-0532-4beb-9a68-7c524ead3eb1)


Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
balance: adding the possibility to buy "ES-4 stun magazine" for 10 point
in the portable vendor.
fix: remove a bunch of ammo that where improper for ES-4 gun that are in
the lockbox.
/:cl:

---------

Co-authored-by: Julien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Huffie56 Huffie56

Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix having inapropriate ammo in CL lockbox. Huffie56/cmss13
2 participants
@MusselMain @Huffie56