Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carrier -> Eggsac strain keeps facehugger sprite overlay #3994

Closed
3 tasks done
Ben10083 opened this issue Jul 25, 2023 · 0 comments · Fixed by #4298
Closed
3 tasks done

Carrier -> Eggsac strain keeps facehugger sprite overlay #3994

Ben10083 opened this issue Jul 25, 2023 · 0 comments · Fixed by #4298
Labels
Bug Admin events aren't bugs Sprites Remove the soul from the game.

Comments

@Ben10083
Copy link
Contributor

Testmerges

N/A

Description of the bug

image

PR: #3868

When switching to eggsac strain, the facehugger sprite overlay is not removed, causing a combination.

What's the difference with what should have happened?

removal of sprite overlay for facehuggers, with just eggsac

How do we reproduce this bug?

  1. Go Carrier
  2. Get facehuggers to get overlay
  3. Switch to eggsac
  4. See both overlays applied
    ...

Issue Bingo
@Ben10083 Ben10083 added the Bug Admin events aren't bugs label Jul 25, 2023
@Huffie56 Huffie56 self-assigned this Aug 4, 2023
@Huffie56 Huffie56 added the Sprites Remove the soul from the game. label Aug 4, 2023
@Huffie56 Huffie56 removed their assignment Aug 8, 2023
@Birdtalon Birdtalon mentioned this issue Aug 31, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 5, 2023
@Birdtalon
Fix carrier mutation sprite update (#4298)
ce53a89 
# About the pull request

Fixes #3994 

# Explain why it's good for the game

Fixes issue

# Testing Photographs and Procedure
Tested in local instance. Set huggers to 16 qty and then purchase the
strain.
`update_hugger_overlays()` was running with the eggsac mutation type. So
it would just return and not actually update the icon. It now updates
correctly before applying the eggsac icon.
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: fixed eggsac carrier strain not updating hugger sprites.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs Sprites Remove the soul from the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix carrier mutation sprite update Birdtalon/cmss13
2 participants
@Ben10083 @Huffie56