Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire Extinguishers on the Lifeboats Have no Water Inside Them. #3998

Closed
3 tasks done
dadlips opened this issue Jul 26, 2023 · 4 comments · Fixed by #5009
Closed
3 tasks done

Fire Extinguishers on the Lifeboats Have no Water Inside Them. #3998

dadlips opened this issue Jul 26, 2023 · 4 comments · Fixed by #5009
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!

Comments

@dadlips
Copy link

dadlips commented Jul 26, 2023

Testmerges

#3962 #3917 #3843 #3985

Description of the bug

Grab a fire extinguisher from the neat little lockers built into the lifeboat > turn off the safety on the fire extinguisher > immediately find out that they have no water inside. I have not had the chance to try and fill one of these extingushers up since if the life boats doors are opened, worse things are happening.

Have a video of the issue: https://streamable.com/31a25l

What's the difference with what should have happened?

Fire extinguishers on the lifeboats should have water inside of them :)

How do we reproduce this bug?

  1. Enter the Lifeboat and Grab a fire extinguisher
  2. Examine the fire extinguisher, no water is inside.
  3. Attempt to use the fire extinguisher, nothing happens.
    ...

Issue Bingo
@dadlips dadlips added the Bug Admin events aren't bugs label Jul 26, 2023
@Huffie56
Copy link
Contributor

Huffie56 commented Jul 31, 2023 •
edited
Loading

that's weird i look into it and the extinguisher is totally bug out i think it's because it's set in the lifeboat and isn't in a vendor....

@Huffie56 Huffie56 assigned Huffie56 and unassigned Huffie56 Jul 31, 2023
@Huffie56
Copy link
Contributor

Huffie56 commented Aug 1, 2023

hello @mullenpaul sorry to bother you but since you ported new shuttle system....
could you tell me if the extinguisher in the shuttle cabinet being bugged is because of how shuttle are loaded in the game?

@mullenpaul
Copy link
Contributor

It shouldn't be an issue. My guess would be that the included extinguisher has no water when it spawns?

@Huffie56
Copy link
Contributor

Huffie56 commented Aug 1, 2023

s would be that the included extinguisher has no water when it

as far as i understand the extinguisher cabinet use same code as the one in brig it just use a reskin.
the extinguisher in the cabinet of the lifeboat is totally bugged you can't refill it...
my wild guess:
could it be that it doesn't do the initialization since the step is before shuttle is spawn?

@Huffie56 Huffie56 added the Confirmed Bug We have the same at home! label Oct 13, 2023
@Birdtalon Birdtalon mentioned this issue Nov 22, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 24, 2023
@Birdtalon
Fixes runtime with fire extinguisher cabinets on lifeboats (#5009)
2b3cf3f 
# About the pull request
Fixes #3998

Fire extinguisher cabinets now new() a fire extinguisher properly in
`Intialize()`

# Explain why it's good for the game

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Lifeboats fire extinguisher runtime.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes runtime with fire extinguisher cabinets on lifeboats Birdtalon/cmss13
3 participants
@mullenpaul @Huffie56 @dadlips