Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a Lesser Drone has ghosted, you cannot see your position in the larva queue. #4183

Closed
3 tasks done
gitbirb opened this issue Aug 14, 2023 · 1 comment · Fixed by #4506
Closed
3 tasks done

If a Lesser Drone has ghosted, you cannot see your position in the larva queue. #4183

gitbirb opened this issue Aug 14, 2023 · 1 comment · Fixed by #4506
Labels
Bug Admin events aren't bugs

Comments

@gitbirb
Copy link

gitbirb commented Aug 14, 2023

Testmerges

#4003: 'Brings automatic weaponry to the marine and surv arsenal' by Zonespace27 at commit 054ef53 #4171: 'More random slashes take two' by morrowwolf at commit 2caecfc #2536: 'OOC prefix proc' by realforest2001 at commit d4e2984 #4160: 'Adds Provost radio & radio channel' by realforest2001 at commit 4b7cf4d #4156: 'Helmet Visors/Optics and built-in HUDs' by morrowwolf at commit 4e93674 #4181: 'fixes the redis bridge ' by harryob at commit e7e5863 #4182: 'Project ARES: Admin Console' by realforest2001 at commit a2adfbd

Description of the bug

If a Lesser Drone has ghosted, you cannot see your position in queue. This is because instead of showing the (Nth position in queue) message, it just opens the join as xenomorph prompt.

What's the difference with what should have happened?

You should be able to see your position in queue, even if a lesser drone has ghosted. (noone ever takes the ghosted lesser drones)

How do we reproduce this bug?

  1. Ghost as lesser drone
  2. Wait until you should have a position in queue
  3. Use "join as xenomorph" button to try seeing your position in queue.
  4. Lesser drone blocks it.
    ...

Issue Bingo
@gitbirb gitbirb added the Bug Admin events aren't bugs label Aug 14, 2023
@gitbirb gitbirb changed the title If a Lesser Drone has ghosted, you cannot see your position in queue. If a Lesser Drone has ghosted, you cannot see your position in the larva queue. Aug 14, 2023
@gitbirb
Copy link
Author

gitbirb commented Aug 14, 2023

hold on i might have tested this wrong. Closing and then reopening once i can test more.

@gitbirb gitbirb closed this as completed Aug 14, 2023
@gitbirb gitbirb reopened this Sep 25, 2023
@Drulikar Drulikar mentioned this issue Sep 25, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2023
@Drulikar
Add cached larva queue message to observer status panel (#4506)
8522fac 
# About the pull request

This PR simply places the cached larva queue message into an observer's
status panel if they have xeno preference set. The spans are removed
from the cache because the status panel doesn't parse spans.

# Explain why it's good for the game

More or less fixes #4183 by putting the message also into the status
panel.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/76988376/30a510e6-0f70-4752-ae3a-a035e732ed76)

</details>


# Changelog
:cl: Drathek
add: Add the last larva queue message to observer's status panel
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cached larva queue message to observer status panel Drulikar/cmss13
1 participant
@gitbirb