Flaming around corners

[StrangeIy]

Testmerges

#4003: 'Brings automatic weaponry to the marine and surv arsenal' by Zonespace27 at commit 054ef53 #2536: 'OOC prefix proc' by realforest2001 at commit d4e2984 #4182: 'Project ARES: Admin Console' by realforest2001 at commit e0d7378 #4131: 'Telephones Networking' by realforest2001 at commit 992e759 #3865: 'New UPP guns' by CapCamIII at commit 1f28d00 #4178: 'Overwatch Console TGUI Refactor' by TheGamerdk at commit fb1a4b1

Description of the bug

Using the flamethrower (M240 or M240-T,) around corners that are doors or shutters, results in the flame simply being one tile and stopping where the door/shutter is. I've tested this on the live server, and on my own private server with an up-to-date copy of CMSS13. Shooting directly through the door/shutter works fine, but shooting around it is where the issue arises. I'm not sure if this is intentional so I apologize if it is.

What's the difference with what should have happened?

The flame path should be able to go around the corner and continue where the user clicks, instead it stops at the tile where the door/shutter is.

How do we reproduce this bug?

1. Use the flamethrower and stand beside the door at a tile above/below, or to the left or right of it depending on its placement.
2. "Fire" the flamethrower at any destination beyond the door where typically the flame should be able to go

Desktop.2023.08.15.-.14.05.40.04.DVR_Trim.2.mp4

Desktop.2023.08.15.-.14.05.40.04.DVR_Trim.mp4

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[Huffie56]

@StrangeIy do you feel like it's the doors that do that? does it happen if you fire behind an open door in a straight line?
it seem like it block when it encounter a second door on is path-finding?

[StrangeIy]

If you fire directly through the door the flame works fine, it's when you're adjacent to the door/shutter that it seems to stop. The first and second video's flame path only crosses one door/shutter. I feel like it's the doors that cause it, cause corner flaming with walls seems to work fine.

[ihatethisengine]

I was always under the impression that it was intended. It's not hard to use the flamethrower properly and avoid fire being "eaten" by corners once you notice this mechanic. I feel like changing this would be a huge buff, since you will be able to use flamer from complete safety (which is realistic though).

[Huffie56]

this probably change how path is calculating.#5212
so need confirmation this bug is still a thing....