Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BiMex personal shades protect eyes against welding. #4190

Closed
3 tasks done
dadlips opened this issue Aug 16, 2023 · 0 comments · Fixed by #4212
Closed
3 tasks done

BiMex personal shades protect eyes against welding. #4190

dadlips opened this issue Aug 16, 2023 · 0 comments · Fixed by #4212
Labels
Consistency Issue Who needs consistency?

Comments

@dadlips
Copy link

dadlips commented Aug 16, 2023 •
edited
Loading

Testmerges

#4003, #2536, #4182, #4131, #3865, #4178

Description of the bug

BiMex personal shades protect your eyes while welding. Simply equip them on your eyes or mask slot and weld away.

I know the description says it protects the user from nuclear flash incidents but I'm not sure if that's a joke or not.
While I wish this was intended I imagine it's probably not.

What's the difference with what should have happened?

Sunglasses maybe shouldn't protect our eyes while welding. Especially if they only cost 2 points in character creation.

How do we reproduce this bug?

1.Equip a sick pair of BiMex personal shades.
2.Weld.
3.No eye damage.
...

Issue Bingo
@dadlips dadlips added the Bug Admin events aren't bugs label Aug 16, 2023
@Huffie56 Huffie56 added Consistency Issue Who needs consistency? and removed Bug Admin events aren't bugs labels Aug 16, 2023
@Diegoflores31 Diegoflores31 mentioned this issue Aug 20, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 26, 2023
@Diegoflores31 @harryob
eyecheck fix (#4212)
72d4396 
# About the pull request

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
fixes #4190 
bug bad

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: Glasses with flash protection can no longer be used for welding.
refactor: Adds defines for negative welding protection.
/:cl:

---------

Co-authored-by: harryob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Consistency Issue Who needs consistency?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

eyecheck fix Diegoflores31/cmss13-D
2 participants
@Huffie56 @dadlips