Research Chemical Duplication

[Weuyn]

Testmerges

#4003: 'Brings automatic weaponry to the marine and surv arsenal' by Zonespace27 at commit db622ab #4182: 'Project ARES: Admin Console' by realforest2001 at commit cb4d971 #4131: 'Telephones Networking' by realforest2001 at commit 992e759 #3865: 'New UPP guns' by CapCamIII at commit 2b2ba4a #4035: 'Faction Access & Almayer Security Overhaul' by realforest2001 at commit 59b8745 #4111: 'Project ARES: Functional Access Tickets' by realforest2001 at commit da5106e Local commit: 30805a71e553a9fbfc906da9a86a1ac83725f70d TGS version: 5.13.7

Description of the bug

You can mix chemicals in a certain way to duplicate them and massively overload containers

What's the difference with what should have happened?

it probably shouldn't double for free

How do we reproduce this bug?

1. produce two variants of the same base chemical by relating, or amplifying or suppressing.
2. Add 420u of one variant to a janitor bucket
3. Add 20u of each of the three reagents of the other variant to the bucket
   (if all was working correctly, the bucket should be filled with 450u of variant two)
4. Something magical will happen intsead, the bucket will be filled with 900u of variant two, exactly double.
   ...

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[Diegoflores31]

i dont quite understand but . we do have a mechanic that basically absorbs older variants into new variants or smth like that

[Weuyn]

Yeah and it works except when the container is nearly full, then instead of absorbing it doubles the volume and goes way over the containers capacity. 900u in a janitors bucket that can usually only hold 500u!

Fill bucket with 420u var A
Add 60u of reagents (20/20/20) var B, get 900u of var B
Split 900u into two 420u var B
Add 120u of reagents (60 in each bucket) var A, get 1800u of var A
Split 1800u into four 420u var A
Add 240u of reagents (60 in each bucket) var B, get 3600u

3600u from a starting 420u of chemical and 420u of reagent!

[Huffie56]

damn why are you closing everyone of your PR @Weuyn ?