Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xenomorph Grab Intent doesn't work #4244

Closed
3 tasks done
private-tristan opened this issue Aug 24, 2023 · 0 comments · Fixed by #4246
Closed
3 tasks done

Xenomorph Grab Intent doesn't work #4244

private-tristan opened this issue Aug 24, 2023 · 0 comments · Fixed by #4246
Labels
Bug Admin events aren't bugs

Comments

@private-tristan
Copy link
Contributor

Testmerges

#3865: 'New UPP guns' by CapCamIII at commit df9d2ca #4063: 'Yautja Change Holder' by realforest2001 at commit 377eeb300e #4224: 'ARES Change Holder' by realforest2001 at commit 06e5019 #4067: 'Research Biohazard Lockdown' by realforest2001 at commit a71df91 #4229: 'fancy lighting' by harryob at commit 78e3b07 #4231: 'Changes nutrition with blood loss' by morrowwolf at commit a38fd4c

Description of the bug

clicking with grab intent doesn't actually grab. cntrl + click works as expected.

What's the difference with what should have happened?

when clicking a draggable target with grab intent, it should actually let you grab. you are forced to use cntrl + click to grab

How do we reproduce this bug?

  1. play as xeno
  2. spawn a human
  3. switch to grab
  4. click on human
  5. message for grab shows up in chat
  6. look at hands, realize there's no "grab" item
  7. try to drag the human
  8. nothing happens and you move away normally.
    ...

Issue Bingo
@private-tristan private-tristan added the Bug Admin events aren't bugs label Aug 24, 2023
@Drulikar Drulikar mentioned this issue Aug 24, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 5, 2023
@Drulikar
Move xeno grab cooldown change to just ctrl+click logic (#4246)
73355dc 
# About the pull request

This PR is a followup to #4204 that introduced a cooldown to grabbing to
fix an exploit. Unfortunately this broke logic for xeno grab intent
click though because that logic pre-emptively is adjusting next_move
(that xenos just override and ignore anyways), so now the cooldown check
is added to just ctrl+click. Technically this means that human
ctrl+click *could* be affected by this change, but I haven't currently
found any effects of this.

# Explain why it's good for the game

Fixes #4244 

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

https://youtu.be/BMRnHIa967Q

</details>


# Changelog
:cl: Drathek
fix: Fixed xeno grab intent
/:cl:
@Grisiuem Grisiuem mentioned this issue Sep 10, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move xeno grab cooldown change to just ctrl+click logic Drulikar/cmss13
1 participant
@private-tristan