Delayed input for xeno swapping abilities

[ThiccFucc]

Testmerges

#4246: 'Move xeno grab cooldown change to just ctrl+click logic' by Drulikar at commit d4a4aeb #4224: 'ARES Change Holder' by realforest2001 at commit eeb44eb #4063: 'Yautja Change Holder' by realforest2001 at commit 377eeb300e #4274: 'Add flanking possiblities to the lifeboat by adding two clamp with doors on each exterior side.' by Huffie56 at commit 3694dbf #4178: 'Overwatch Console TGUI Refactor' by TheGamerdk at commit 167c088 #4241: 'notify ghosts' by harryob at commit 4c8b87b #4280: 'Lesser drone changes' by morrowwolf at commit 324a59f

Description of the bug

In my case I was a warrior, pounced a marine, started getting shot. Instantly swapped to fling to ungrapple them so I could escape, but realized too late that the swap to fling never registered. Thought it was just me, but then others in dchat were saying they had similar issues with toggling different abilities as xeno. This has happened on several occasions.

What's the difference with what should have happened?

Toggled ability should have swapped to fling when I hit the bind for it.

How do we reproduce this bug?

1. Queue up for xeno roundstart
2. Evolve to warrior
3. Lunge a marine
4. Try to swap to fling immediately after the pounce
5. (might be able to reproduce with other castes such as vanguard?)
   ...

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[ihatethisengine]

I noticed some weird input delays lately as well, but cannot say I encounter them every round. One round on BR input delay was so bad, my pounce was interrupted by movement which I did before the pounce (for real, I am not this bad at the game, and it happened 4 times that round and never before or after). Movement itself felt very delayed as well, it was quite inconvenient to navigate. I complained in hivemind, but no one seemed to suffer similar issues. So it might be some weird client issue.

[Drulikar]

Going to need a lot more specifics than these reproduction steps, because this does not appear to be reproducible.

E.g. HOW are you activating the lunge ability, on what/who (e.g. happens when lunging a SG, but not rifleman; using MMB pref or shift+click pref?), and HOW are you swapping to the other ability (clicking the ability? Using a byond macro? Using the hotkey system? What binding in the hotkey system?) Also when this happens, does your ping shoot up? What is the round number when this occurs so we can look to see if there are errors getting spit out?

[Drulikar]

For example locally, using the current TGS commit c4d6807057f777203f2e0808073687b65965c991 using MMB preference and the pictured keybinds (my mouse is sending , on MMB4 and . on MMB5)

fling.mp4

[ThiccFucc]

MMB preference
My lunge is bound to V, fling bound to Z, X bound to swap hands. I've done this through the hotkey system on CM.

Hit V to select lunge
Middle click on a marine
Hit X to swap hands, start slashing and moving backwards while dragging the marine
Hit Z to select fling

OR

Hit V to select lunge
Middle click on a marine
Hit Z to select fling immediately after pounce
Hit X to swap hands, start slashing and moving backwards while dragging the marine
(realizes fling didn't select)(dies)

I think the second one is what I usually do; hope that helps!

Personally I haven't noticed it occurring when pouncing any specific marines
Haven't noticed spikes in ping, but I'll try watching for them more; there might be a bit of lag sometimes cause there's often an SG deathball around when it happens
One round it happened was last night, ID 18414; died first pounce in a hallway.
I think it happened the next round too, 18415, that's when some other people in dchat started saying they were having the same issue.

I have noticed delays when swapping hands too sometimes immediately after a pounce, that doesn't register either. I don't know if I'm just hitting the second macro too fast after pounce for it to register, but if that's the case idk if it's a game issue that could be fixed