Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashlights no longer change their animation after turned off by slashing #4361

Closed
3 tasks done
Faunenschnitt opened this issue Sep 8, 2023 · 0 comments · Fixed by #4493
Closed
3 tasks done

Flashlights no longer change their animation after turned off by slashing #4361

Faunenschnitt opened this issue Sep 8, 2023 · 0 comments · Fixed by #4493
Labels
Bug Admin events aren't bugs

Comments

@Faunenschnitt
Copy link

Testmerges

#4224: 'ARES Change Holder' by realforest2001 at commit 1a51892266#4063: 'Yautja Change Holder' by realforest2001 at commit 377eeb300e#4336: 'Gives the M56D full auto' by Zonespace27 at commit b2c8ce509f#4352: 'Cryorine changes' by morrowwolf at commit 320307fdb7#4353: 'End game timing changes' by morrowwolf at commit 3ab8848bed#4354: 'Cryo spec one time tech purchase' by morrowwolf at commit 30aed51875#4344: 'Maybe fixes an issue with burst firing' by Zonespace27 at commit 977b356

Description of the bug

There used to be a different picture/animation for turned off flashlights, but it was lost at some point. If they are now turned on and you slash them to turn the light off, they turn off (i.e. there is no light anymore from it) but the animation does not change anymore.

I think that this appeared since the lightning change but might be a coincidence. Bug is in there since some time so it is not related to any current TM.

What's the difference with what should have happened?

Turned off flashlights should not have the turned on animation after being turned off.

How do we reproduce this bug?

  1. turn on flashlight
  2. slash it
  3. hear the clicking sound and see that the light goes out
  4. see that the animation still shows the flashlight as emitting light despite being off

Issue Bingo

@Faunenschnitt Faunenschnitt added the Bug Admin events aren't bugs label Sep 8, 2023
github-merge-queue bot pushed a commit that referenced this issue Sep 27, 2023
…ash. (#4493)

# About the pull request

When slashed off, a flashlight would maintain it's 'on' sprite. Now it
updates correctly.

Fixes #4361

# Changelog

:cl: Casper
fix: fixed flashlights showing incorrect sprite state
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant